This is an archive of the discontinued LLVM Phabricator instance.

Differential D18027

[lto] Initialize asmparsers.
ClosedPublic

Authored by silvas on Mar 9 2016, 9:01 PM.

Details

Reviewers
ruiu
• rafael
Commits
rG03e41ee6a780: [lto] Initialize asmparsers.
rLLD263094: [lto] Initialize asmparsers.
rL263094: [lto] Initialize asmparsers.
Summary

They are needed for inline asm during LTO.

In particular we hit the report_fatal_error on
llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:138

LLVM ERROR: Inline asm not supported by this streamer because we don't have an asm parser for this target

Diff Detail

Event Timeline

silvas updated this revision to Diff 50233.Mar 9 2016, 9:01 PM
silvas retitled this revision from to [lto] Initialize asmparsers..
silvas updated this object.
silvas added reviewers: ruiu, • rafael.
silvas added subscribers: llvm-commits, Bigcheese.
Herald added a subscriber: mehdi_amini. · View Herald TranscriptMar 9 2016, 9:01 PM
ruiu accepted this revision.Mar 9 2016, 9:02 PM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 9 2016, 9:02 PM
Closed by commit rL263094: [lto] Initialize asmparsers. (authored by silvas). · Explain WhyMar 9 2016, 9:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
ELF/
1 line
test/
ELF/
lto/
11 lines

Diff 50233

ELF/Driver.cpp

Show First 20 Lines • Show All 315 Lines • ▼ Show 20 Lines if (Files.empty() && !HasError)
error("no input files."); error("no input files.");
} }
template <class ELFT> void LinkerDriver::link(opt::InputArgList &Args) { template <class ELFT> void LinkerDriver::link(opt::InputArgList &Args) {
// For LTO // For LTO
InitializeAllTargets(); InitializeAllTargets();
InitializeAllTargetMCs(); InitializeAllTargetMCs();
InitializeAllAsmPrinters(); InitializeAllAsmPrinters();
InitializeAllAsmParsers();
SymbolTable<ELFT> Symtab; SymbolTable<ELFT> Symtab;
std::unique_ptr<TargetInfo> TI(createTarget()); std::unique_ptr<TargetInfo> TI(createTarget());
Target = TI.get(); Target = TI.get();
if (!Config->Shared && !Config->Relocatable) { if (!Config->Shared && !Config->Relocatable) {
// Add entry symbol. // Add entry symbol.
// //
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines

test/ELF/lto/inline-asm.ll

  • This file was added.
; REQUIRES: x86
; RUN: llvm-as %s -o %t.o
; RUN: ld.lld -m elf_x86_64 %t.o -o %t.so -shared
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
define void @foo() {
call void asm "nop", ""()
ret void
}