OpenCL 2.0 supports attribute((nosvm)) but it is not widely used and removed from OpenCL 2.1.
This change allows Clang to accept attribute((nosvm)) for OpenCL but ignores it.
Differential Revision: http://reviews.llvm.org/D17861
Differential D17861
[OpenCL] Accept __attribute__((nosvm)) yaxunl on Mar 3 2016, 12:00 PM. Authored by
Details OpenCL 2.0 supports attribute((nosvm)) but it is not widely used and removed from OpenCL 2.1. This change allows Clang to accept attribute((nosvm)) for OpenCL but ignores it. Differential Revision: http://reviews.llvm.org/D17861
Diff Detail Event Timeline
Comment Actions Revised by Aaron's and Anastasia's comments. Changed error/warning message for invalid usage of nosvm attribute.
Comment Actions LGTM, except for one tiny comment that can be addressed before committing.
|
Please use the language option feature in tabelgen as in your previous patch instead of performing this work manually. We want use of the attribute to provide a different diagnostic in this case because the attribute *isn't* unknown, it simply doesn't apply under the compilation target (and hence is ignored).