Page MenuHomePhabricator

[AMDGPU] Fix for "v_div_scale_f64 reg, vcc, ..." parsing
ClosedPublic

Authored by artem.tamazov on Feb 8 2016, 10:17 AM.

Details

Summary

Added support for "VOP3Only" attribute in VOP3bInst encoding.
Set VOP3Only=1 for V_DIV_SCALE_F64/32 insns.
Added support for multi-dest instructions in AMDGPUAs::cvt*().
Added lit test for "V_DIV_SCALE_F64|F32 vreg,vcc|sreg,vreg,vreg,vreg".

Diff Detail

Repository
rL LLVM

Event Timeline

artem.tamazov retitled this revision from to [AMDGPU] Fix for "v_div_scale_f64 reg, vcc, ..." parsing.
artem.tamazov updated this object.
artem.tamazov set the repository for this revision to rL LLVM.
artem.tamazov added subscribers: vpykhtin, nhaustov, SamWot.
arsenm added inline comments.Feb 8 2016, 10:55 AM
test/MC/AMDGPU/vop3.s
273–275

Should also include a test with another SGPR other than vcc

artem.tamazov updated this object.

Added lit test for V_DIV_SCALE_F64 vreg,sreg,vreg,vreg,vreg.
Added lit test for V_DIV_SCALE_F32 vreg,vcc,vreg,vreg,vreg.
Added lit test for V_DIV_SCALE_F32 vreg,sreg,vreg,vreg,vreg.

arsenm accepted this revision.Feb 8 2016, 11:15 AM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Feb 8 2016, 11:15 AM
arsenm added inline comments.Feb 8 2016, 11:17 AM
test/MC/AMDGPU/vop3.s
285

vcc is still the output operand here, although this test is also useful with another SGPR as first input

artem.tamazov marked an inline comment as done.Feb 8 2016, 11:23 AM
artem.tamazov added inline comments.
test/MC/AMDGPU/vop3.s
285

Opps... Will add valid test in minutes.

artem.tamazov edited edge metadata.

Added valid "v_div_scale_f32, reg, sreg..." test

artem.tamazov added a project: Restricted Project.Feb 12 2016, 8:50 AM