It appears that there is code in glibc that uses this modifier so LLVM should handle it.
Honestly, I could not locate any documentation specifying the semantics of this modifier so I implemented it to have the same behaviour that I observed from GCC. Perhaps if one of the reviewers has this information, you can offer what needs to be done to the operand when the %s modifier is in the template.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Yes, that's the correct behavior, as can be seen at https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01937.html. Note that GCC produces a warning if the wrong operand type is used, but I don't see that as a necessity for something that's deprecated anyway. This patch LGTM.