This is an archive of the discontinued LLVM Phabricator instance.

using /system/bin/sh on android in tests.
ClosedPublic

Authored by aizatsky on Jan 27 2016, 3:39 PM.

Reviewers

Commits

aizatsky retitled this revision from to using /system/bin/sh on android in tests..

aizatsky updated this object.

aizatsky added a subscriber: llvm-commits.

nits

LGTM w/ a nit

lib/sanitizer_common/tests/sanitizer_linux_test.cc
269–276	please invert the condition

This revision is now accepted and ready to land.Jan 27 2016, 3:50 PM

nit

thanks. submitting.

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

sanitizer_common/

tests/

11 lines

	Show First 20 Lines • Show All 260 Lines • ▼ Show 20 Lines
	TEST(SanitizerLinux, ThreadSelfTest) {			TEST(SanitizerLinux, ThreadSelfTest) {
	ASSERT_EQ(pthread_self(), ThreadSelf());			ASSERT_EQ(pthread_self(), ThreadSelf());
	}			}
	#endif			#endif

	TEST(SanitizerCommon, StartSubprocessTest) {			TEST(SanitizerCommon, StartSubprocessTest) {
	int pipe_fds[2];			int pipe_fds[2];
	ASSERT_EQ(0, pipe(pipe_fds));			ASSERT_EQ(0, pipe(pipe_fds));
	const char *argv[] = {"/bin/sh", "-c", "echo -n 'hello'"};			#if SANITIZER_ANDROID
	int pid = StartSubprocess("/bin/sh", const_cast<char **>(&argv[0]),			const char *shell = "/system/bin/sh";
	kInvalidFd /* stdin /, pipe_fds[1] / stdout */);			#else
				const char *shell = "/bin/sh";
				#endif
				const char *argv[] = {shell, "-c", "echo -n 'hello'"};
				int pid = StartSubprocess(shell, argv,
				/* stdin / kInvalidFd, / stdout */ pipe_fds[1]);
				eugenisUnsubmitted Done Reply Inline Actions please invert the condition eugenis: please invert the condition
	ASSERT_GT(pid, 0);			ASSERT_GT(pid, 0);

	// wait for process to finish.			// wait for process to finish.
	while (IsProcessRunning(pid)) {			while (IsProcessRunning(pid)) {
	}			}
	ASSERT_FALSE(IsProcessRunning(pid));			ASSERT_FALSE(IsProcessRunning(pid));

	char buffer[256];			char buffer[256];
	Show All 19 Lines