Page MenuHomePhabricator

Add backend dignostic printer for unsupported features
ClosedPublic

Authored by olista01 on Jan 26 2016, 10:06 AM.

Details

Summary

The related LLVM patch adds a backend diagnostic type for reporting
unsupported features, this adds a printer for them to clang.

In the case where debug location information is not available, I've
changed the printer to report the location as the first line of the
function, rather than the closing brace, as the latter does not give the
user any information. This also affects optimisation remarks.

Diff Detail

Repository
rL LLVM

Event Timeline

olista01 updated this revision to Diff 46009.Jan 26 2016, 10:06 AM
olista01 retitled this revision from to Add backend dignostic printer for unsupported features.
olista01 updated this object.
olista01 added reviewers: ast, sunfish, tstellarAMD.
olista01 set the repository for this revision to rL LLVM.
olista01 added a subscriber: cfe-commits.
ast edited edge metadata.Jan 26 2016, 10:56 AM

looks good.
could you add a testcase for DK_Unsupported ?

olista01 updated this revision to Diff 46127.Jan 27 2016, 6:10 AM
olista01 edited edge metadata.
olista01 removed rL LLVM as the repository for this revision.

Added a test for the new diagnostic printer.

ast accepted this revision.Jan 27 2016, 9:02 AM
ast edited edge metadata.

thanks

This revision is now accepted and ready to land.Jan 27 2016, 9:02 AM
This revision was automatically updated to reflect the committed changes.

This was reverted last night, I've re-committed it as r259036 with the layering violation fixed.