Fix getCompiler in unit testing framework on compiler symlinks

[fjricci]

Summary

Checks using the result of getCompiler() will fail to identify the compiler
correctly if CC is a symlink path (ie /usr/bin/cc).

Use "CC" -v to determine the actual compiler type in these cases.

[fjricci]

Accidentally ran clang-format, fix an indentation error

[zturner]

packages/Python/lldbsuite/test/plugins/builder_base.py

30–39

This works, but I think it could be better. It sounds like what you really want to do is resolve the symlink. What about this:

def getCompiler():
    compiler = os.environ.get("CC", "clang")
    return os.path.realpath(compiler)

[fjricci]

packages/Python/lldbsuite/test/plugins/builder_base.py

30–39

That works, and is much cleaner, thanks!

[fjricci]

Resolve symlink instead of parsing version output

[fjricci]

Clean up imports

[sas]

Committed as r259433.

[labath]

This caused a regression when the compiler was specified without a full path (I've fixed it in r259484, this is just an FYI).

Also, please put @lldb-commits (not LLVM) as a subscriber on the diff next time.

cheers,
pl

[fjricci]

Committed.

packages/Python/lldbsuite/test/plugins/builder_base.py

 
 Same idea holds for LLDB_ARCH environment variable, which maps to the ARCH make
 variable.
 """
 
 import os, sys
 import platform
 import lldbsuite.test.lldbtest as lldbtest
+from subprocess import check_output, STDOUT
 
 def getArchitecture():
     """Returns the architecture in effect the test suite is running with."""
     return os.environ["ARCH"] if "ARCH" in os.environ else ""
 
 def getCompiler():
     """Returns the compiler in effect the test suite is running with."""
-    return os.environ["CC"] if "CC" in os.environ else "clang"
+    compiler = os.environ.get("CC", "clang")
+    return os.path.realpath(compiler)
 
 def getArchFlag():
     """Returns the flag required to specify the arch"""
     compiler = getCompiler()
     if compiler is None:
       return ""
     elif "gcc" in compiler:
       archflag = "-m"
     elif "clang" in compiler:
       archflag = "-arch"
     else:
       archflag = None
 
     return ("ARCHFLAG=" + archflag) if archflag else ""
 
 def getMake():
     """Returns the name for GNU make"""
     if platform.system() == "FreeBSD" or platform.system() == "NetBSD":
       return "gmake"
     else: