If html_cov_report is set and sancov binary is found, the html report would be generated automatically on coverage dump.
|426 ↗||(On Diff #45602)|
|27 ↗||(On Diff #45602)|
this is gross :)
|793 ↗||(On Diff #45602)|
you need InternalScopedString
|830 ↗||(On Diff #45602)|
put this into a separate function
|787 ↗||(On Diff #46038)|
Consider adding an early return here instead
if (!common_flags()->html_cov_report || sancov_args == nullptr)
|800 ↗||(On Diff #46038)|
Don't you want to log unsuccessful attempt to generate html?
|206 ↗||(On Diff #46038)|
Is sancov_path more appropriate flag name?
|144 ↗||(On Diff #46038)|
I think you should use llvm_tools_dir instead. See the way it's handled in test/lit.common.cfg: probably you want to add this functionality there. Also, as LLVM tools directory is in PATH, auto-discovery of "sancov" binary must work in the lit test (in the same way we auto-discover llvm-symbolizer).
|147 ↗||(On Diff #46038)|
You have to explicitly add dependency on "sancov" binary from sanitizer test suites: see test/CMakeLists.txt