Page MenuHomePhabricator

GlobalValue: use getValueType() instead of getType()->getPointerElementType().
ClosedPublic

Authored by eddyb on Jan 16 2016, 11:20 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

eddyb updated this revision to Diff 45078.Jan 16 2016, 11:20 AM
eddyb retitled this revision from to GlobalValue: use getValueType() instead of getType()->getPointerElementType()..
eddyb updated this object.
eddyb added a reviewer: mjacob.
eddyb added a subscriber: dblaikie.
mjacob edited edge metadata.Jan 16 2016, 11:47 AM

Otherwise it looks fine to me.

lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
86 ↗(On Diff #45078)

Shouldn't this be dyn_cast<GlobalValue>(Ptr)?

tools/bugpoint/CrashDebugger.cpp
281 ↗(On Diff #45078)

Strictly speaking, this is an unrelated cleanup.

eddyb updated this revision to Diff 45079.Jan 16 2016, 12:13 PM
eddyb edited edge metadata.

Address review comments.

eddyb marked an inline comment as done.Jan 16 2016, 12:16 PM
mjacob accepted this revision.Jan 16 2016, 12:19 PM
mjacob edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jan 16 2016, 12:19 PM
This revision was automatically updated to reflect the committed changes.
mjacob edited edge metadata.Jan 16 2016, 3:17 PM
mjacob added a subscriber: llvm-commits.