Page MenuHomePhabricator

eddyb (Eduard Burtescu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 27 2015, 1:40 AM (273 w, 7 h)

Recent Activity

Dec 15 2017

eddyb added a comment to D41296: Limit size of non-GlobalValue name.

For the record, this patch alone appears to have a significant impact on the original bug report the testcase here was derived from (via bugpoint), and while there may be a remaining underlying issue with SROA, it's valuable by itself.

Dec 15 2017, 11:27 AM · Restricted Project

Mar 7 2016

eddyb added a comment to D17901: Re-add ConstantFoldInstOperands form taking opcode and return type..

LGTM, the assert seems to be the main difference from my original patch.

Mar 7 2016, 1:26 AM

Jan 24 2016

eddyb added inline comments to D16417: [opaque pointer types] [NFC] {Load,Store}Inst: get loaded/stored type from the instruction..
Jan 24 2016, 1:31 PM

Jan 21 2016

eddyb added a comment to D16425: [opaque pointer types] [NFC] isDereferenceable{,AndAligned}Pointer: take the accessed size (and alignment) as arguments..

Sorry @dblaikie, but I almost missed these comments as they weren't showing up in Differential.

Jan 21 2016, 9:15 PM
eddyb committed rL258481: [opaque pointer types] [NFC] Fix fallout from DataLayout::getIndexedOffset….
[opaque pointer types] [NFC] Fix fallout from DataLayout::getIndexedOffset…
Jan 21 2016, 7:47 PM
eddyb committed rL258478: [opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source….
[opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source…
Jan 21 2016, 7:12 PM
eddyb closed D16282: [opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source element type instead of pointer type and rename to getIndexedOffsetInType. by committing rL258478: [opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source….
Jan 21 2016, 7:12 PM
eddyb added inline comments to D16425: [opaque pointer types] [NFC] isDereferenceable{,AndAligned}Pointer: take the accessed size (and alignment) as arguments..
Jan 21 2016, 6:39 PM
eddyb added inline comments to D16425: [opaque pointer types] [NFC] isDereferenceable{,AndAligned}Pointer: take the accessed size (and alignment) as arguments..
Jan 21 2016, 6:14 PM
eddyb committed rL258477: [opaque pointer types] [NFC] FindAvailableLoadedValue: take LoadInst instead….
[opaque pointer types] [NFC] FindAvailableLoadedValue: take LoadInst instead…
Jan 21 2016, 5:55 PM
eddyb closed D16422: [opaque pointer types] [NFC] FindAvailableLoadedValue: take LoadInst instead of just the pointer. by committing rL258477: [opaque pointer types] [NFC] FindAvailableLoadedValue: take LoadInst instead….
Jan 21 2016, 5:55 PM
eddyb added inline comments to D16425: [opaque pointer types] [NFC] isDereferenceable{,AndAligned}Pointer: take the accessed size (and alignment) as arguments..
Jan 21 2016, 5:47 PM
eddyb retitled D16282: [opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source element type instead of pointer type and rename to getIndexedOffsetInType. from [opaque pointer types] [breaking-change] [NFC] Refactor gep_type_iterator and getIndexedOffset not to touch PointerType::getElementType. to [opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source element type instead of pointer type and rename to getIndexedOffsetInType..
Jan 21 2016, 5:43 PM
eddyb updated the diff for D16282: [opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source element type instead of pointer type and rename to getIndexedOffsetInType..

Rebased on top of rL258474.

Jan 21 2016, 5:42 PM
eddyb committed rL258474: [opaque pointer types] [NFC] gep_type_{begin,end} now take source element….
[opaque pointer types] [NFC] gep_type_{begin,end} now take source element…
Jan 21 2016, 5:37 PM
eddyb closed D16436: [opaque pointer types] [NFC] gep_type_{begin,end} now take source element type and address space. by committing rL258474: [opaque pointer types] [NFC] gep_type_{begin,end} now take source element….
Jan 21 2016, 5:37 PM
eddyb retitled D16436: [opaque pointer types] [NFC] gep_type_{begin,end} now take source element type and address space. from to [opaque pointer types] [NFC] gep_type_{begin,end} now take source element type and address space..
Jan 21 2016, 5:25 PM
eddyb committed rL258472: [opaque pointer types] [NFC] Add an explicit type argument to….
[opaque pointer types] [NFC] Add an explicit type argument to…
Jan 21 2016, 5:21 PM
eddyb closed D16418: [opaque pointer types] [NFC] Add an explicit type argument to ConstantFoldLoadFromConstPtr. by committing rL258472: [opaque pointer types] [NFC] Add an explicit type argument to….
Jan 21 2016, 5:21 PM
eddyb added inline comments to D16418: [opaque pointer types] [NFC] Add an explicit type argument to ConstantFoldLoadFromConstPtr..
Jan 21 2016, 5:10 PM
eddyb updated D16282: [opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source element type instead of pointer type and rename to getIndexedOffsetInType..
Jan 21 2016, 4:01 PM
eddyb committed rL258456: [opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType….
[opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType…
Jan 21 2016, 3:46 PM
eddyb closed D16302: [opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType when folding GEPs. by committing rL258456: [opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType….
Jan 21 2016, 3:46 PM
eddyb added inline comments to D16302: [opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType when folding GEPs..
Jan 21 2016, 3:35 PM
eddyb added inline comments to D16417: [opaque pointer types] [NFC] {Load,Store}Inst: get loaded/stored type from the instruction..
Jan 21 2016, 3:33 PM
eddyb added inline comments to D16417: [opaque pointer types] [NFC] {Load,Store}Inst: get loaded/stored type from the instruction..
Jan 21 2016, 3:26 PM
eddyb updated the diff for D16282: [opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source element type instead of pointer type and rename to getIndexedOffsetInType..

Rebased to account for renames in D16282.

Jan 21 2016, 2:43 PM
eddyb retitled D16426: [NFC] LoadInst: add two helper methods: getLoadedSize and getActualAlignment. from to [NFC] LoadInst: add two helper methods: getLoadedSize and getActualAlignment..
Jan 21 2016, 12:14 PM
eddyb retitled D16425: [opaque pointer types] [NFC] isDereferenceable{,AndAligned}Pointer: take the accessed size (and alignment) as arguments. from to [opaque pointer types] [NFC] isDereferenceable{,AndAligned}Pointer: take the accessed size (and alignment) as arguments..
Jan 21 2016, 12:08 PM
eddyb retitled D16422: [opaque pointer types] [NFC] FindAvailableLoadedValue: take LoadInst instead of just the pointer. from to [opaque pointer types] [NFC] FindAvailableLoadedValue: take LoadInst instead of just the pointer..
Jan 21 2016, 11:21 AM
eddyb retitled D16418: [opaque pointer types] [NFC] Add an explicit type argument to ConstantFoldLoadFromConstPtr. from to [opaque pointer types] [NFC] Add an explicit type argument to ConstantFoldLoadFromConstPtr..
Jan 21 2016, 10:44 AM
eddyb retitled D16417: [opaque pointer types] [NFC] {Load,Store}Inst: get loaded/stored type from the instruction. from to [opaque pointer types] [NFC] {Load,Store}Inst: get loaded/stored type from the instruction..
Jan 21 2016, 10:43 AM
eddyb updated the diff for D16302: [opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType when folding GEPs..

Moved the invocation of SymbolicallyEvaluateGEP and its StructType handling to simplify the patch.

Jan 21 2016, 10:41 AM

Jan 20 2016

eddyb retitled D16302: [opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType when folding GEPs. from [opaque pointer types] [NFC] ConstantFoldInstOperands: add a form taking the Instruction or ConstantExpr for GEPs. to [opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType when folding GEPs..
Jan 20 2016, 8:26 PM
eddyb updated the diff for D16302: [opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType when folding GEPs..

Rebased on top D16383.

Jan 20 2016, 8:26 PM
eddyb accepted D16383: Change ConstantFoldInstOperands to take Instruction instead of opcode and type. NFC..

LGTM

Jan 20 2016, 6:00 PM
eddyb accepted D16380: Introduce ConstantFoldCastOperand function and migrate some callers of ConstantFoldInstOperands to use it. NFC..

LGTM

Jan 20 2016, 4:53 PM
eddyb accepted D16378: Introduce ConstantFoldBinaryOpOperands function and migrate some callers of ConstantFoldInstOperands to use it. NFC..

LGTM

Jan 20 2016, 3:20 PM

Jan 19 2016

eddyb committed rL258262: [NFC] Replace several manual GEP loops with gep_type_iterator..
[NFC] Replace several manual GEP loops with gep_type_iterator.
Jan 19 2016, 4:30 PM
eddyb closed D16335: [NFC] Replace several manual GEP loops with gep_type_iterator. by committing rL258262: [NFC] Replace several manual GEP loops with gep_type_iterator..
Jan 19 2016, 4:30 PM
eddyb added inline comments to D16302: [opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType when folding GEPs..
Jan 19 2016, 4:29 PM
eddyb retitled D16335: [NFC] Replace several manual GEP loops with gep_type_iterator. from to [NFC] Replace several manual GEP loops with gep_type_iterator..
Jan 19 2016, 4:12 PM
eddyb added inline comments to D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType..
Jan 19 2016, 3:34 PM
eddyb updated the diff for D16282: [opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source element type instead of pointer type and rename to getIndexedOffsetInType..

Rebased on top of D16302 (on top of trunk).

Jan 19 2016, 9:45 AM
eddyb updated D16282: [opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source element type instead of pointer type and rename to getIndexedOffsetInType..
Jan 19 2016, 9:43 AM
eddyb updated D16282: [opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source element type instead of pointer type and rename to getIndexedOffsetInType..
Jan 19 2016, 9:37 AM
eddyb updated D16302: [opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType when folding GEPs..
Jan 19 2016, 9:37 AM
eddyb updated the diff for D16302: [opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType when folding GEPs..

Rebased on top of rL258145.

Jan 19 2016, 9:36 AM
eddyb committed rL258145: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with….
[opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with…
Jan 19 2016, 9:32 AM
eddyb closed D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType. by committing rL258145: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with….
Jan 19 2016, 9:32 AM
eddyb updated the diff for D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType..

Rebased on top of rL258134.

Jan 19 2016, 8:56 AM
eddyb accepted D16321: Fix constant folding of constant vector GEPs with undef or null as pointer argument..

LGTM

Jan 19 2016, 8:33 AM

Jan 18 2016

eddyb updated the diff for D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType..

Address review comments.

Jan 18 2016, 4:14 PM
eddyb updated D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType..
Jan 18 2016, 4:08 PM
eddyb added inline comments to D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType..
Jan 18 2016, 2:50 PM
eddyb retitled D16302: [opaque pointer types] [NFC] Take advantage of get{Source,Result}ElementType when folding GEPs. from to [opaque pointer types] [NFC] ConstantFoldInstOperands: add a form taking the Instruction or ConstantExpr for GEPs..
Jan 18 2016, 12:50 PM
eddyb updated the diff for D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType..

Remove change that depends on other patches (and does nullptr deref right now).

Jan 18 2016, 11:18 AM
eddyb updated D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType..
Jan 18 2016, 8:53 AM
eddyb updated the diff for D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType..

Simplified the first commit and took out the second one to shorten this revision.

Jan 18 2016, 8:52 AM

Jan 17 2016

eddyb added a reviewer for D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType.: dblaikie.
Jan 17 2016, 4:40 PM
eddyb committed rL258029: Revert assert added in rL258028 as the alloca and OtherPtr types may differ….
Revert assert added in rL258028 as the alloca and OtherPtr types may differ…
Jan 17 2016, 4:24 PM
eddyb committed rL258028: [opaque pointer types] Alloca: use getAllocatedType() instead of getType()….
[opaque pointer types] Alloca: use getAllocatedType() instead of getType()…
Jan 17 2016, 4:14 PM
eddyb closed D16272: [opaque pointer types] Alloca: use getAllocatedType() instead of getType()->getElementType(). by committing rL258028: [opaque pointer types] Alloca: use getAllocatedType() instead of getType()….
Jan 17 2016, 4:13 PM
eddyb added a comment to D16272: [opaque pointer types] Alloca: use getAllocatedType() instead of getType()->getElementType()..
Jan 17 2016, 4:01 PM
eddyb updated the diff for D16272: [opaque pointer types] Alloca: use getAllocatedType() instead of getType()->getElementType()..

Assert that OtherPtr still has the same pointer type as the alloca.

Jan 17 2016, 4:01 PM
eddyb added a comment to D16272: [opaque pointer types] Alloca: use getAllocatedType() instead of getType()->getElementType()..
Jan 17 2016, 3:39 PM
eddyb updated the diff for D16272: [opaque pointer types] Alloca: use getAllocatedType() instead of getType()->getElementType()..

Reuse EltPtr variable, with a more precise type.

Jan 17 2016, 3:38 PM
eddyb abandoned D16265: [opaque pointer types] GEP: replace getPointerElementType uses with get{Source,Result}ElementType..

I've split this up as well, only 2 reviews left are http://reviews.llvm.org/D16275 and http://reviews.llvm.org/D16282.

Jan 17 2016, 2:56 PM
eddyb retitled D16282: [opaque pointer types] [NFC] DataLayout::getIndexedOffset: take source element type instead of pointer type and rename to getIndexedOffsetInType. from to [opaque pointer types] [breaking-change] [NFC] Refactor gep_type_iterator and getIndexedOffset not to touch PointerType::getElementType..
Jan 17 2016, 2:54 PM
eddyb retitled D16281: [opaque pointer types] [breaking-change] [NFC] SimplifyGEPInst: take the source element type of the GEP as an argument. from to [opaque pointer types] [breaking-change] [NFC] SimplifyGEPInst: take the source element type of the GEP as an argument..
Jan 17 2016, 2:31 PM
eddyb added inline comments to D16273: [opaque pointer types] CallSite: use getFunctionType() instead of going through PointerType::getElementType..
Jan 17 2016, 2:26 PM
eddyb added inline comments to D16272: [opaque pointer types] Alloca: use getAllocatedType() instead of getType()->getElementType()..
Jan 17 2016, 1:11 PM
eddyb updated the diff for D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType..

Fixed missing PtrTy in ScalarReplAggregates.cpp's CanConvertToScalar.

Jan 17 2016, 1:03 PM
eddyb retitled D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType. from [opaque pointer types] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType. to [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType..
Jan 17 2016, 12:57 PM
eddyb retitled D16275: [opaque pointer types] [NFC] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType. from to [opaque pointer types] GEP: replace get(Pointer)ElementType uses with get{Source,Result}ElementType..
Jan 17 2016, 12:46 PM
eddyb retitled D16274: Remove one dead PointerType::getElementType() call. from Remove one dead getPointerElementType() call. to Remove one dead PointerType::getElementType() call..
Jan 17 2016, 12:35 PM
eddyb retitled D16273: [opaque pointer types] CallSite: use getFunctionType() instead of going through PointerType::getElementType. from [opaque pointer types] CallSite: use getFunctionType() instead of going through getPointerElementType. to [opaque pointer types] CallSite: use getFunctionType() instead of going through PointerType::getElementType..
Jan 17 2016, 12:34 PM
eddyb retitled D16272: [opaque pointer types] Alloca: use getAllocatedType() instead of getType()->getElementType(). from [opaque pointer types] Alloca: use getAllocatedType() instead of getType()->getPointerElementType(). to [opaque pointer types] Alloca: use getAllocatedType() instead of getType()->getElementType()..
Jan 17 2016, 12:33 PM
eddyb retitled D16274: Remove one dead PointerType::getElementType() call. from to Remove one dead getPointerElementType() call..
Jan 17 2016, 11:29 AM
eddyb retitled D16273: [opaque pointer types] CallSite: use getFunctionType() instead of going through PointerType::getElementType. from to [opaque pointer types] CallSite: use getFunctionType() instead of going through getPointerElementType..
Jan 17 2016, 11:27 AM
eddyb retitled D16272: [opaque pointer types] Alloca: use getAllocatedType() instead of getType()->getElementType(). from to [opaque pointer types] Alloca: use getAllocatedType() instead of getType()->getPointerElementType()..
Jan 17 2016, 11:24 AM
eddyb abandoned D16266: [opaque pointer types] Miscellaneous getPointerElementType cleanups..

Splitting into more patches, my bad.

Jan 17 2016, 11:19 AM

Jan 16 2016

eddyb retitled D16266: [opaque pointer types] Miscellaneous getPointerElementType cleanups. from to [opaque pointer types] Miscellaneous getPointerElementType cleanups..
Jan 16 2016, 5:14 PM
eddyb retitled D16265: [opaque pointer types] GEP: replace getPointerElementType uses with get{Source,Result}ElementType. from to [opaque pointer types] GEP: replace getPointerElementType uses with get{Source,Result}ElementType..
Jan 16 2016, 4:59 PM
eddyb abandoned D15689: [opaque pointer types] Prune some uses of PointerType::getElementType..

I've followed mjacob's advice and started filing each part of this large patch separately.

Jan 16 2016, 3:50 PM
eddyb added a comment to D16260: GlobalValue: use getValueType() instead of getType()->getPointerElementType()..
Jan 16 2016, 12:16 PM
eddyb updated the diff for D16260: GlobalValue: use getValueType() instead of getType()->getPointerElementType()..

Address review comments.

Jan 16 2016, 12:13 PM
eddyb retitled D16260: GlobalValue: use getValueType() instead of getType()->getPointerElementType(). from to GlobalValue: use getValueType() instead of getType()->getPointerElementType()..
Jan 16 2016, 11:20 AM

Dec 21 2015

eddyb retitled D15689: [opaque pointer types] Prune some uses of PointerType::getElementType. from [opaque pointer types] Prune some uses of PointerType::getElementType. Breaking API changes: * PointerType no longer inherits from SequentialType * PointerType::getElementType deprecated in favor of getPointerElementType * Type... to [opaque pointer types] Prune some uses of PointerType::getElementType..
Dec 21 2015, 6:45 AM
eddyb retitled D15689: [opaque pointer types] Prune some uses of PointerType::getElementType. from to [opaque pointer types] Prune some uses of PointerType::getElementType. Breaking API changes: * PointerType no longer inherits from SequentialType * PointerType::getElementType deprecated in favor of getPointerElementType * Type....
Dec 21 2015, 6:42 AM