Page MenuHomePhabricator

[llvm-readobj] Add support for TLSDESC_PLT and TLSDESC_GOT dynamic section tags to the llvm-readobj.
ClosedPublic

Authored by grimar on Jan 15 2016, 7:35 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar updated this revision to Diff 44989.Jan 15 2016, 7:35 AM
grimar retitled this revision from to [llvm-reaobj] Add support for TLSDESC_PLT and TLSDESC_GOT dynamic section tags to the llvm-readobj..
grimar updated this object.
grimar added reviewers: Bigcheese, echristo, rafael.
grimar retitled this revision from [llvm-reaobj] Add support for TLSDESC_PLT and TLSDESC_GOT dynamic section tags to the llvm-readobj. to [llvm-readobj] Add support for TLSDESC_PLT and TLSDESC_GOT dynamic section tags to the llvm-readobj..
grimar added subscribers: llvm-commits, grimar.
davide accepted this revision.Jan 15 2016, 9:28 AM
davide added a reviewer: davide.
davide added a subscriber: davide.

looks good, thanks.

This revision is now accepted and ready to land.Jan 15 2016, 9:28 AM
davide added inline comments.Jan 15 2016, 9:30 AM
tools/llvm-readobj/ELFDumper.cpp
1341 ↗(On Diff #44989)

Just put these in the right place (before RELA, that is).

grimar added inline comments.Jan 15 2016, 9:46 AM
tools/llvm-readobj/ELFDumper.cpp
1341 ↗(On Diff #44989)

Hmm, I think its in the right place now. I put it in according of their constant values:

DT_GNU_HASH     = 0x6FFFFEF5, // Reference to the GNU hash table.
DT_TLSDESC_PLT  = 0x6FFFFEF6, // Location of PLT entry for TLS descriptor resolver calls.
DT_TLSDESC_GOT  = 0x6FFFFEF7, // Location of GOT entry used by TLS descriptor resolver PLT entry.
DT_RELACOUNT    = 0x6FFFFFF9, // ELF32_Rela count.
DT_RELCOUNT     = 0x6FFFFFFA, // ELF32_Rel count.

Isn`t that correct ?

The whole set of cases is uncorrectly sorted (it was even before you). Looking again, I think the place where you put is correct, I still think it's worth doing a pass (in a different commit) to sort that properly. Go ahead and submit.

The whole set of cases is uncorrectly sorted (it was even before you). Looking again, I think the place where you put is correct, I still think it's worth doing a pass (in a different commit) to sort that properly. Go ahead and submit.

Thanks for review ! I`ll commit once http://reviews.llvm.org/D16185 is approved, because it is the direct dependency for this one..

This revision was automatically updated to reflect the committed changes.