[libcxx] <experimental/simd> excluded long double for 32-bits x86 temporarily

[mstorsjo]

libcxx/test/std/experimental/simd/test_utils.h

44

It should be quite enough to just check for __i386__ here - I don't know of any case where __i686__ is defined but __i386__ isn't.

FWIW, the previous condition of checking for #ifdef __MINGW32__ did cover 64 bit mingw too which I presume wasn't intended; the __MINGW32__ define is set for all mingw targets, even on 64 bit (just like _WIN32 is defined for all win32 api targets, regardless of whether they're 32 or 64 bit).

[mgorny]

Thanks. I've tested with just __i386__, and I can confirm I no longer get test failures in 32-bit build with this change. The 64-bit test run is still ongoing but I think it's unlikely for this to break it.

[Joy12138]

check for i386 only

[Joy12138]

@philnik Hi! This is ready to be accepted. Thanks!

[mgorny]

Ping.

[mgorny]

@Joy12138, could you merge it now? This is blocking us from testing new snapshots of LLVM.

[philnik]

@mgorny Would it be possible to add the configuration you use to the precommit CI?

[mgorny]

In D159514#4650250, @philnik wrote:

@mgorny Would it be possible to add the configuration you use to the precommit CI?

I don't know anything about precommit CI. We're basically building it using C++ compiler set to i686-pc-linux-gnu-clang++ that's symlink to the amd64 build of clang (and via the filename magic forces -m32).

libcxx/test/std/experimental/simd/test_utils.h

struct TestAllSimdAbiFunctor {
   void operator()() {
     using abis = types::type_list<ex::simd_abi::scalar, ex::simd_abi::native<T>, ex::simd_abi::compatible<T>>;
     types::for_each(abis{}, F<T, 1>());
 
     instantiate_with_n<T>(std::make_index_sequence<max_simd_size - 1>{});
   }
 };
 
-// TODO: Support long double (12 bytes) for MinGW (DLL, i686)
-#ifdef __MINGW32__
+// TODO: Support long double (12 bytes) for 32-bits x86
+#ifdef __i386__
 using arithmetic_no_bool_types = types::concatenate_t<types::integer_types, types::type_list<float, double>>;
 #else
 using arithmetic_no_bool_types = types::concatenate_t<types::integer_types, types::floating_point_types>;
 #endif
 
 template <template <class T, std::size_t N> class Func>
 void test_all_simd_abi() {
   types::for_each(arithmetic_no_bool_types(), TestAllSimdAbiFunctor<Func>());