This is an archive of the discontinued LLVM Phabricator instance.

Differential D159509

[libcxx] <experimental/simd> Fix CI errors on 32-bits x86
ClosedPublic

Authored by Joy12138 on Sep 12 2023, 10:31 PM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rGadae4e9b5c98: [libcxx] <experimental/simd> Fix CI errors on 32-bits x86

Diff Detail

Unit TestsFailed

TimeTest
28,480 mslibcxx-ci - Debug mode > llvm-libc++-shared-cfg-in.std/experimental/simd/simd_class::simd_ctor_broadcast.pass.cpp
5,040 mslibcxx-ci - Debug mode > llvm-libc++-shared-cfg-in.std/experimental/simd/simd_mask_class::simd_mask_ctor_broadcast.pass.cpp
30,010 mslibcxx-ci - Safe mode > llvm-libc++-shared-cfg-in.std/experimental/simd/simd_class::simd_ctor_broadcast.pass.cpp
5,290 mslibcxx-ci - Safe mode > llvm-libc++-shared-cfg-in.std/experimental/simd/simd_mask_class::simd_mask_ctor_broadcast.pass.cpp

Event Timeline

Joy12138 created this revision.Sep 12 2023, 10:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2023, 10:31 PM
Herald added subscribers: mstorsjo, miyuki. · View Herald Transcript
Joy12138 requested review of this revision.Sep 12 2023, 10:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2023, 10:31 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Joy12138 mentioned this in D144363: [libcxx] <experimental/simd> Added simd width functions, simd_size traits and related tests.Sep 12 2023, 10:34 PM
Joy12138 mentioned this in D156225: [libcxx] <experimental/simd> Add broadcast constructor of class simd/simd_mask.
Joy12138 updated this revision to Diff 556625.Sep 12 2023, 10:36 PM

Fix comment

philnik accepted this revision.Sep 12 2023, 10:36 PM
This revision is now accepted and ready to land.Sep 12 2023, 10:36 PM
var-const mentioned this in D159065: [libc++][hardening] Make the safe mode pipeline run with modules enabled.Sep 12 2023, 11:08 PM
Harbormaster completed remote builds in B257118: Diff 556625.Sep 13 2023, 12:06 AM
Joy12138 updated this revision to Diff 556631.Sep 13 2023, 12:08 AM

Fix index range

Harbormaster completed remote builds in B257122: Diff 556631.Sep 13 2023, 2:11 AM
Closed by commit rGadae4e9b5c98: [libcxx] <experimental/simd> Fix CI errors on 32-bits x86 (authored by Joy12138). · Explain WhySep 13 2023, 2:13 AM
This revision was automatically updated to reflect the committed changes.
Joy12138 added a commit: rGadae4e9b5c98: [libcxx] <experimental/simd> Fix CI errors on 32-bits x86.

Revision Contents

PathSize
libcxx/
test/
std/
experimental/
simd/
4 lines

Diff 556625

libcxx/test/std/experimental/simd/test_utils.h

Show All 34 Linesstruct TestAllSimdAbiFunctor {
void operator()() { void operator()() {
using abis = types::type_list<ex::simd_abi::scalar, ex::simd_abi::native<T>, ex::simd_abi::compatible<T>>; using abis = types::type_list<ex::simd_abi::scalar, ex::simd_abi::native<T>, ex::simd_abi::compatible<T>>;
types::for_each(abis{}, F<T, 1>()); types::for_each(abis{}, F<T, 1>());
instantiate_with_n<T>(std::make_index_sequence<max_simd_size - 1>{}); instantiate_with_n<T>(std::make_index_sequence<max_simd_size - 1>{});
} }
}; };
// TODO: Support long double (12 bytes) for MinGW (DLL, i686) // TODO: Support long double (12 bytes) on 32-bit x86
#ifdef __MINGW32__ #if defined(__i386__) || defined(__i686__)
using arithmetic_no_bool_types = types::concatenate_t<types::integer_types, types::type_list<float, double>>; using arithmetic_no_bool_types = types::concatenate_t<types::integer_types, types::type_list<float, double>>;
#else #else
using arithmetic_no_bool_types = types::concatenate_t<types::integer_types, types::floating_point_types>; using arithmetic_no_bool_types = types::concatenate_t<types::integer_types, types::floating_point_types>;
#endif #endif
template <template <class T, std::size_t N> class Func> template <template <class T, std::size_t N> class Func>
void test_all_simd_abi() { void test_all_simd_abi() {
types::for_each(arithmetic_no_bool_types(), TestAllSimdAbiFunctor<Func>()); types::for_each(arithmetic_no_bool_types(), TestAllSimdAbiFunctor<Func>());
Show All 29 Lines