This is an archive of the discontinued LLVM Phabricator instance.

Differential D159509

[libcxx] <experimental/simd> Fix CI errors on 32-bits x86
ClosedPublic

Authored by Joy12138 on Sep 12 2023, 10:31 PM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rGadae4e9b5c98: [libcxx] <experimental/simd> Fix CI errors on 32-bits x86

Diff Detail

Event Timeline

Joy12138 created this revision.Sep 12 2023, 10:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2023, 10:31 PM
Herald added subscribers: mstorsjo, miyuki. · View Herald Transcript
Joy12138 requested review of this revision.Sep 12 2023, 10:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2023, 10:31 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Joy12138 mentioned this in D144363: [libcxx] <experimental/simd> Added simd width functions, simd_size traits and related tests.Sep 12 2023, 10:34 PM
Joy12138 mentioned this in D156225: [libcxx] <experimental/simd> Add broadcast constructor of class simd/simd_mask.
Joy12138 updated this revision to Diff 556625.Sep 12 2023, 10:36 PM

Fix comment

philnik accepted this revision.Sep 12 2023, 10:36 PM
This revision is now accepted and ready to land.Sep 12 2023, 10:36 PM
var-const mentioned this in D159065: [libc++][hardening] Make the safe mode pipeline run with modules enabled.Sep 12 2023, 11:08 PM
Harbormaster completed remote builds in B257118: Diff 556625.Sep 13 2023, 12:06 AM
Joy12138 updated this revision to Diff 556631.Sep 13 2023, 12:08 AM

Fix index range

Harbormaster completed remote builds in B257122: Diff 556631.Sep 13 2023, 2:11 AM
Closed by commit rGadae4e9b5c98: [libcxx] <experimental/simd> Fix CI errors on 32-bits x86 (authored by Joy12138). · Explain WhySep 13 2023, 2:13 AM
This revision was automatically updated to reflect the committed changes.
Joy12138 added a commit: rGadae4e9b5c98: [libcxx] <experimental/simd> Fix CI errors on 32-bits x86.

Revision Contents

PathSize
libcxx/
include/
experimental/
__simd/
4 lines

Diff 556636

libcxx/include/experimental/__simd/vec_ext.h

Show All 25 Lines
}; };
} // namespace simd_abi } // namespace simd_abi
template <class _Tp, int _Np> template <class _Tp, int _Np>
struct __simd_storage<_Tp, simd_abi::__vec_ext<_Np>> { struct __simd_storage<_Tp, simd_abi::__vec_ext<_Np>> {
_Tp __data __attribute__((__vector_size__(std::__bit_ceil((sizeof(_Tp) * _Np))))); _Tp __data __attribute__((__vector_size__(std::__bit_ceil((sizeof(_Tp) * _Np)))));
_Tp __get(size_t __idx) const noexcept { _Tp __get(size_t __idx) const noexcept {
_LIBCPP_ASSERT_UNCATEGORIZED(__idx > 0 && __idx <= _Np, "Index is out of bounds"); _LIBCPP_ASSERT_UNCATEGORIZED(__idx >= 0 && __idx < _Np, "Index is out of bounds");
return __data[__idx]; return __data[__idx];
} }
void __set(size_t __idx, _Tp __v) noexcept { void __set(size_t __idx, _Tp __v) noexcept {
_LIBCPP_ASSERT_UNCATEGORIZED(__idx > 0 && __idx <= _Np, "Index is out of bounds"); _LIBCPP_ASSERT_UNCATEGORIZED(__idx >= 0 && __idx < _Np, "Index is out of bounds");
__data[__idx] = __v; __data[__idx] = __v;
} }
}; };
template <class _Tp, int _Np> template <class _Tp, int _Np>
struct __mask_storage<_Tp, simd_abi::__vec_ext<_Np>> struct __mask_storage<_Tp, simd_abi::__vec_ext<_Np>>
: __simd_storage<decltype(experimental::__choose_mask_type<_Tp>()), simd_abi::__vec_ext<_Np>> {}; : __simd_storage<decltype(experimental::__choose_mask_type<_Tp>()), simd_abi::__vec_ext<_Np>> {};
Show All 33 Lines