This is an archive of the discontinued LLVM Phabricator instance.

Differential D159472

Add apply_scale check for a case where the input is i64 in TosaToArith
AbandonedPublic

Authored by NatashaKnk on Sep 6 2023, 1:38 PM.

Details

Reviewers
rsuderman

Diff Detail

Event Timeline

NatashaKnk created this revision.Sep 6 2023, 1:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2023, 1:38 PM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 25 others. · View Herald Transcript
NatashaKnk requested review of this revision.Sep 6 2023, 1:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2023, 1:38 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
NatashaKnk updated this revision to Diff 556078.Sep 6 2023, 1:39 PM

Fix test

NatashaKnk added a reviewer: rsuderman.Sep 6 2023, 1:40 PM
Harbormaster completed remote builds in B256745: Diff 556078.Sep 6 2023, 1:40 PM
NatashaKnk updated this revision to Diff 556079.Sep 6 2023, 1:46 PM

Fix test case

Harbormaster completed remote builds in B256746: Diff 556079.Sep 6 2023, 1:46 PM
NatashaKnk abandoned this revision.Sep 6 2023, 1:46 PM

Revision Contents

PathSize
mlir/
test/
Conversion/
TosaToArith/
5 lines

Diff 556079

mlir/test/Conversion/TosaToArith/tosa-to-arith.mlir

Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Linesfunc.func @apply_scale_test_i48(%arg0 : i48, %arg1 : i32, %arg2 : i8) -> (i32) {
// Shift and truncate final answer. // Shift and truncate final answer.
// CHECK-DAG: %[[SHR:.+]] = arith.shrsi %[[RES64]], %[[S64]] // CHECK-DAG: %[[SHR:.+]] = arith.shrsi %[[RES64]], %[[S64]]
// CHECK-DAG: %[[TRUNC:.+]] = arith.trunci %[[SHR]] : i64 to i32 // CHECK-DAG: %[[TRUNC:.+]] = arith.trunci %[[SHR]] : i64 to i32
// CHECK: return %[[TRUNC]] // CHECK: return %[[TRUNC]]
%res = tosa.apply_scale %arg0, %arg1, %arg2 {double_round = true} : (i48, i32, i8) -> i32 %res = tosa.apply_scale %arg0, %arg1, %arg2 {double_round = true} : (i48, i32, i8) -> i32
return %res : i32 return %res : i32
} }
// -----
// CHECK-LABEL: @apply_scale_test_i64 // CHECK-LABEL: @apply_scale_test_i64
// SCALE: tosa.apply_scale // SCALE: tosa.apply_scale
func.func @apply_scale_test_i64(%arg0 : i64, %arg1 : i32, %arg2 : i8) -> (i32) { func.func @apply_scale_test_i64(%arg0 : i64, %arg1 : i32, %arg2 : i8) -> (i32) {
// CHECK-DAG: %[[C0:.+]] = arith.constant 0 : i48 // CHECK-DAG: %[[C0:.+]] = arith.constant 0 : i64
// CHECK-DAG: %[[C1:.+]] = arith.constant 1 : i64 // CHECK-DAG: %[[C1:.+]] = arith.constant 1 : i64
// CHECK-DAG: %[[C31:.+]] = arith.constant 31 : i32 // CHECK-DAG: %[[C31:.+]] = arith.constant 31 : i32
// Multiply in 64 bits. // Multiply in 64 bits.
// CHECK-DAG: %[[M64:.+]] = arith.extsi %arg1 : i32 to i64 // CHECK-DAG: %[[M64:.+]] = arith.extsi %arg1 : i32 to i64
// CHECK-DAG: %[[MUL:.+]] = arith.muli %arg0, %[[M64]] // CHECK-DAG: %[[MUL:.+]] = arith.muli %arg0, %[[M64]]
// Round normally. // Round normally.
Show All 14 Linesfunc.func @apply_scale_test_i64(%arg0 : i64, %arg1 : i32, %arg2 : i8) -> (i32) {
// Shift and truncate final answer. // Shift and truncate final answer.
// CHECK-DAG: %[[SHR:.+]] = arith.shrsi %[[RES64]], %[[S64]] // CHECK-DAG: %[[SHR:.+]] = arith.shrsi %[[RES64]], %[[S64]]
// CHECK-DAG: %[[TRUNC:.+]] = arith.trunci %[[SHR]] : i64 to i32 // CHECK-DAG: %[[TRUNC:.+]] = arith.trunci %[[SHR]] : i64 to i32
// CHECK: return %[[TRUNC]] // CHECK: return %[[TRUNC]]
%res = tosa.apply_scale %arg0, %arg1, %arg2 {double_round = true} : (i64, i32, i8) -> i32 %res = tosa.apply_scale %arg0, %arg1, %arg2 {double_round = true} : (i64, i32, i8) -> i32
return %res : i32 return %res : i32
} }
No newline at end of file No newline at end of file