This is an archive of the discontinued LLVM Phabricator instance.

[libc++abi][test][VE] Add UNSUPPORTED to pass tests on VE
ClosedPublic

Authored by kaz7 on Sep 5 2023, 6:51 AM.

Details

Summary

Add UNSUPPORTED to pass tests on VE. VE uses SjLj libunwind, so
_Unwind_Backtrace and _Unwind_ForcedUnwind are not implemented.

Diff Detail

Event Timeline

kaz7 created this revision.Sep 5 2023, 6:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2023, 6:51 AM
kaz7 requested review of this revision.Sep 5 2023, 6:51 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2023, 6:51 AM
MaskRay accepted this revision.Sep 5 2023, 1:04 PM
MaskRay added inline comments.
libcxxabi/test/forced_unwind2.pass.cpp
13
kaz7 updated this revision to Diff 555951.Sep 5 2023, 4:16 PM
kaz7 marked an inline comment as done.

Update comments.

libcxxabi/test/forced_unwind2.pass.cpp
13

Thanks!

kaz7 added a comment.Sep 12 2023, 7:13 PM

ping. Is it possible to get approval from libc++abi group? Thanks!

ldionne accepted this revision.Sep 13 2023, 3:25 PM
This revision is now accepted and ready to land.Sep 13 2023, 3:25 PM
This revision was landed with ongoing or failed builds.Sep 13 2023, 4:13 PM
This revision was automatically updated to reflect the committed changes.