Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D159446

[libc++abi][test][VE] Add UNSUPPORTED to pass tests on VE
ClosedPublic
Actions

Authored by kaz7 on Tue, Sep 5, 6:51 AM.

Details

Reviewers
efocht
phosek
MaskRay
jdoerfert
ldionne
Group Reviewers
Restricted Project
Commits
rG9a220dc6abd6: [libc++abi][test][VE] Add UNSUPPORTED to pass tests on VE
Summary

Add UNSUPPORTED to pass tests on VE. VE uses SjLj libunwind, so
_Unwind_Backtrace and _Unwind_ForcedUnwind are not implemented.

Diff Detail

Event Timeline

kaz7 created this revision.Tue, Sep 5, 6:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Sep 5, 6:51 AM
kaz7 requested review of this revision.Tue, Sep 5, 6:51 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Sep 5, 6:51 AM
Herald added a subscriber: libcxx-commits. · View Herald Transcript
MaskRay accepted this revision.Tue, Sep 5, 1:04 PM
MaskRay added inline comments.
libcxxabi/test/forced_unwind2.pass.cpp
13
kaz7 updated this revision to Diff 555951.Tue, Sep 5, 4:16 PM
kaz7 marked an inline comment as done.

Update comments.

libcxxabi/test/forced_unwind2.pass.cpp
13

Thanks!

kaz7 added a comment.Tue, Sep 12, 7:13 PM

ping. Is it possible to get approval from libc++abi group? Thanks!

ldionne accepted this revision.Wed, Sep 13, 3:25 PM
This revision is now accepted and ready to land.Wed, Sep 13, 3:25 PM
This revision was landed with ongoing or failed builds.Wed, Sep 13, 4:13 PM
Closed by commit rG9a220dc6abd6: [libc++abi][test][VE] Add UNSUPPORTED to pass tests on VE (authored by kaz7). · Explain Why
This revision was automatically updated to reflect the committed changes.
kaz7 added a commit: rG9a220dc6abd6: [libc++abi][test][VE] Add UNSUPPORTED to pass tests on VE.

Revision Contents
Changeset List

Diff 556731

View Options

libcxxabi/test/backtrace_test.pass.cpp

Loading...
View Options

libcxxabi/test/forced_unwind1.pass.cpp

Loading...
View Options

libcxxabi/test/forced_unwind2.pass.cpp

Loading...
View Options

libcxxabi/test/forced_unwind3.pass.cpp

Loading...