This is an archive of the discontinued LLVM Phabricator instance.

libclc: Fix signed integer underflow in abs_diff
ClosedPublic

Authored by frasercrmck on Aug 31 2023, 5:47 AM.

Details

Summary

We noticed this same issue in our own implementation of abs_diff, and
the same issue also came up in the abs_diff reference function in the
OpenCL CTS.

Diff Detail

Event Timeline

frasercrmck created this revision.Aug 31 2023, 5:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2023, 5:47 AM
frasercrmck requested review of this revision.Aug 31 2023, 5:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2023, 5:47 AM
frasercrmck retitled this revision from libclc: Fix signed interger underflow in abs_diff to libclc: Fix signed integer underflow in abs_diff.Aug 31 2023, 5:48 AM
This revision is now accepted and ready to land.Aug 31 2023, 6:09 AM
This revision was landed with ongoing or failed builds.Aug 31 2023, 6:28 AM
This revision was automatically updated to reflect the committed changes.