This is an archive of the discontinued LLVM Phabricator instance.

Differential D159260

[Flang][Driver] Add support for backend passes in R_Group
ClosedPublic

Authored by victorkingi on Aug 31 2023, 2:19 AM.

Details

Reviewers
sscalpone
awarzynski
kiranchandramohan
Commits
rGe87d2d2cc9c4: [Flang][Driver] Add support for backend passes in R_Group
Summary

Previously, R_Group options only reported middle-end passes.
This patch allows backend passes to be reported as well.

Depends on D158174. That patch adds backend support to R_Group
options.

Diff Detail

Unit TestsFailed

TimeTest
120 msx64 Debian > Flang.Driver::optimization-remark-backend.f90

Event Timeline

victorkingi created this revision.Aug 31 2023, 2:19 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptAug 31 2023, 2:19 AM
Herald added a reviewer: awarzynski. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
victorkingi requested review of this revision.Aug 31 2023, 2:19 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptAug 31 2023, 2:19 AM
awarzynski accepted this revision.Aug 31 2023, 2:26 AM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 31 2023, 2:26 AM
awarzynski added a reviewer: kiranchandramohan.Aug 31 2023, 2:34 AM
Harbormaster completed remote builds in B255952: Diff 554944.Aug 31 2023, 2:55 AM
victorkingi updated this revision to Diff 554972.Aug 31 2023, 4:12 AM

'MISSED' and 'ANALYSIS' to 'MISSED-DAG' and 'ANALYSIS-DAG' in optimization-remark-backend.f90

Harbormaster completed remote builds in B255974: Diff 554972.Aug 31 2023, 4:36 AM
victorkingi updated this revision to Diff 555036.Aug 31 2023, 7:20 AM

Removed remark option in test file to fix failing test

victorkingi added a child revision: D159258: [Flang][Driver] Add location and remark option printing to R_Group Diagnostics.Aug 31 2023, 7:31 AM
Harbormaster completed remote builds in B256019: Diff 555036.Aug 31 2023, 7:31 AM
This revision was landed with ongoing or failed builds.Aug 31 2023, 7:40 AM
Closed by commit rGe87d2d2cc9c4: [Flang][Driver] Add support for backend passes in R_Group (authored by Victor Kingi <victor.kingi@arm.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Victor Kingi <victor.kingi@arm.com> added a commit: rGe87d2d2cc9c4: [Flang][Driver] Add support for backend passes in R_Group.

Revision Contents

PathSize
flang/
lib/
Frontend/
13 lines
test/
Driver/
21 lines

Diff 554972

flang/lib/Frontend/FrontendActions.cpp

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
#include "clang/Basic/Diagnostic.h" #include "clang/Basic/Diagnostic.h"
#include "clang/Basic/DiagnosticFrontend.h" #include "clang/Basic/DiagnosticFrontend.h"
#include "clang/Driver/DriverDiagnostic.h" #include "clang/Driver/DriverDiagnostic.h"
#include "llvm/ADT/SmallString.h" #include "llvm/ADT/SmallString.h"
#include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringRef.h"
#include "llvm/Analysis/TargetLibraryInfo.h" #include "llvm/Analysis/TargetLibraryInfo.h"
#include "llvm/Analysis/TargetTransformInfo.h" #include "llvm/Analysis/TargetTransformInfo.h"
#include "llvm/Bitcode/BitcodeWriterPass.h" #include "llvm/Bitcode/BitcodeWriterPass.h"
#include "llvm/CodeGen/MachineOptimizationRemarkEmitter.h"
#include "llvm/IR/LLVMRemarkStreamer.h" #include "llvm/IR/LLVMRemarkStreamer.h"
#include "llvm/IR/LegacyPassManager.h" #include "llvm/IR/LegacyPassManager.h"
#include "llvm/IR/Verifier.h" #include "llvm/IR/Verifier.h"
#include "llvm/IRReader/IRReader.h" #include "llvm/IRReader/IRReader.h"
#include "llvm/MC/TargetRegistry.h" #include "llvm/MC/TargetRegistry.h"
#include "llvm/Object/OffloadBinary.h" #include "llvm/Object/OffloadBinary.h"
#include "llvm/Passes/PassBuilder.h" #include "llvm/Passes/PassBuilder.h"
#include "llvm/Passes/PassPlugin.h" #include "llvm/Passes/PassPlugin.h"
▲ Show 20 Lines • Show All 958 Lines • ▼ Show 20 Lines case llvm::DK_OptimizationRemark:
break; break;
case llvm::DK_OptimizationRemarkMissed: case llvm::DK_OptimizationRemarkMissed:
optimizationRemarkHandler(llvm::cast<llvm::OptimizationRemarkMissed>(di)); optimizationRemarkHandler(llvm::cast<llvm::OptimizationRemarkMissed>(di));
break; break;
case llvm::DK_OptimizationRemarkAnalysis: case llvm::DK_OptimizationRemarkAnalysis:
optimizationRemarkHandler( optimizationRemarkHandler(
llvm::cast<llvm::OptimizationRemarkAnalysis>(di)); llvm::cast<llvm::OptimizationRemarkAnalysis>(di));
break; break;
case llvm::DK_MachineOptimizationRemark:
optimizationRemarkHandler(
llvm::cast<llvm::MachineOptimizationRemark>(di));
break;
case llvm::DK_MachineOptimizationRemarkMissed:
optimizationRemarkHandler(
llvm::cast<llvm::MachineOptimizationRemarkMissed>(di));
break;
case llvm::DK_MachineOptimizationRemarkAnalysis:
optimizationRemarkHandler(
llvm::cast<llvm::MachineOptimizationRemarkAnalysis>(di));
break;
default: default:
break; break;
} }
return true; return true;
} }
}; };
void CodeGenAction::embedOffloadObjects() { void CodeGenAction::embedOffloadObjects() {
▲ Show 20 Lines • Show All 196 Lines • Show Last 20 Lines

flang/test/Driver/optimization-remark-backend.f90

  • This file was added.
! This file tests backend passes emitted by the -Rpass family of flags
! loop-delete isn't enabled at O0 so we use at least O1
! DEFINE: %{output} = -S -o /dev/null 2>&1
! RUN: %flang %s -O1 -Rpass-missed %{output} 2>&1 | FileCheck %s --check-prefix=MISSED
! RUN: %flang %s -O1 -Rpass-analysis %{output} 2>&1 | FileCheck %s --check-prefix=ANALYSIS
! MISSED-DAG: remark: {{[0-9]+}} virtual registers copies {{.*}} total copies cost generated in function [-Rpass-missed=regalloc]
! ANALYSIS-DAG: remark: BasicBlock:
! ANALYSIS-DAG: [-Rpass-analysis=asm-printer]
program forttest
implicit none
integer :: n
do n = 1,2
print *, ""
end do
end program forttest