Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D159183

[LoongArch] Support llvm.is.fpclass for f32 and f64
ClosedPublic
Actions

Authored by SixWeining on Wed, Aug 30, 2:58 AM.

Details

Reviewers
xen0n
xry111
arsenm
wangleiat
Commits
rG419f90e93aad: [LoongArch] Support llvm.is.fpclass for f32 and f64
Summary

is_fpclass (fj, mask)
->
sltu (r0, and (movfr2gr.[sd] (fclass.[sd] fj), (to_fclass_mask mask)))

[1]: https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html#_fclass_sd

Diff Detail

Event Timeline

SixWeining created this revision.Wed, Aug 30, 2:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Aug 30, 2:58 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
SixWeining requested review of this revision.Wed, Aug 30, 2:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Aug 30, 2:58 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
SixWeining updated this revision to Diff 554926.Thu, Aug 31, 1:06 AM
SixWeining edited the summary of this revision. (Show Details)

Sorry. The encoding (bits[6:9]) does not match llvm.is.fpclass's second argument. I must be dizzy. Now it is revised.

Harbormaster completed remote builds in B255936: Diff 554926.Thu, Aug 31, 2:00 AM
wangleiat accepted this revision.Tue, Sep 12, 1:05 AM

LGTM

This revision is now accepted and ready to land.Tue, Sep 12, 1:05 AM
This revision was landed with ongoing or failed builds.Thu, Sep 14, 12:44 AM
Closed by commit rG419f90e93aad: [LoongArch] Support llvm.is.fpclass for f32 and f64 (authored by SixWeining). · Explain Why
This revision was automatically updated to reflect the committed changes.
SixWeining added a commit: rG419f90e93aad: [LoongArch] Support llvm.is.fpclass for f32 and f64.
nikic added a subscriber: nikic.Fri, Sep 15, 12:31 AM

This broke the expensive checks build.

SixWeining added a comment.Fri, Sep 15, 1:17 AM
In D159183#4646375, @nikic wrote:

This broke the expensive checks build.

Thanks. Just fixed in 0a692b6b9632e1460f9e0e983196f2be5879acd1

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
LoongArch/
5 lines
13 lines
2 lines
15 lines
26 lines
test/
CodeGen/
LoongArch/
843 lines
1371 lines

Diff 556747

View Options

llvm/lib/Target/LoongArch/LoongArchFloat32InstrInfo.td

Loading...
View Options

llvm/lib/Target/LoongArch/LoongArchFloat64InstrInfo.td

Loading...
View Options

llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp

Loading...
View Options

llvm/lib/Target/LoongArch/LoongArchInstrInfo.h

Loading...
View Options

llvm/lib/Target/LoongArch/LoongArchInstrInfo.td

Loading...
View Options

llvm/test/CodeGen/LoongArch/is_fpclass_f32.ll

Loading...
View Options

llvm/test/CodeGen/LoongArch/is_fpclass_f64.ll

Loading...