[lldb] Add DynamicLoader for FreeBSD Kernel post-mortem debug facility

[aokblast]

Change loaded DynamicLoader plugin for ProcessFreeBSDKernel

[aokblast]

Add relocatable file support for kernel module

[aokblast]

Add subdirectory for DynamicLoader Plugin directory

[emaste]

lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp

115–116 ↗

(On Diff #554237)

kFreeBSD indicates a FreeBSD kernel, typically with some other userland (e.g. Debian GNU/kFreeBSD is Debian's standard userland, with FreeBSD instead of Linux as the kernel). But these projects are mostly not active anymore and I'm not sure how we'd test.

183 ↗

(On Diff #554237)

Add return false; for now as well?

lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

943

The indentation looks wrong on a few lines here,

[aokblast]

Add "real comment" for commented code
Some of my code is commented without showing the reason.
In this comment, I add the reason for it.

[aokblast]

This change fix the indentation for the ObjectFileELF.cpp

lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

lldb_private::Address ObjectFileELF::GetEntryPointAddress() {
   else
     m_entry_point_address.ResolveAddressUsingFileSections(offset, section_list);
   return m_entry_point_address;
 }
 
 Address ObjectFileELF::GetBaseAddress() {
   if (GetType() == ObjectFile::eTypeObjectFile) {
     for (SectionHeaderCollIter I = std::next(m_section_headers.begin());
-   I != m_section_headers.end(); ++I) {
+         I != m_section_headers.end(); ++I) {
       const ELFSectionHeaderInfo &header = *I;
       if (header.sh_flags & SHF_ALLOC)
   return Address(GetSectionList()->FindSectionByID(SectionIndex(I)), 0);
     }
     return LLDB_INVALID_ADDRESS;
   }
 
   for (const auto &EnumPHdr : llvm::enumerate(ProgramHeaders())) {
     const ELFProgramHeader &H = EnumPHdr.value();
     if (H.p_type != PT_LOAD)
       continue;