This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Add DynamicLoader for FreeBSD Kernel post-mortem debug facility
ClosedPublic

Authored by aokblast on Aug 29 2023, 2:38 AM.

Diff Detail

Event Timeline

aokblast created this revision.Aug 29 2023, 2:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2023, 2:38 AM
Herald added a subscriber: emaste. · View Herald Transcript
aokblast requested review of this revision.Aug 29 2023, 2:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2023, 2:38 AM
aokblast updated this revision to Diff 554235.EditedAug 29 2023, 3:05 AM

Change loaded DynamicLoader plugin for ProcessFreeBSDKernel

aokblast updated this revision to Diff 554236.Aug 29 2023, 3:18 AM

Add relocatable file support for kernel module

aokblast updated this revision to Diff 554237.Aug 29 2023, 3:20 AM

Add subdirectory for DynamicLoader Plugin directory

emaste added inline comments.Aug 29 2023, 6:05 AM
lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp
116–117

kFreeBSD indicates a FreeBSD kernel, typically with some other userland (e.g. Debian GNU/kFreeBSD is Debian's standard userland, with FreeBSD instead of Linux as the kernel). But these projects are mostly not active anymore and I'm not sure how we'd test.

184

Add return false; for now as well?

lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
943 ↗(On Diff #554237)

The indentation looks wrong on a few lines here,

aokblast updated this revision to Diff 554722.EditedAug 30 2023, 7:42 AM

Add "real comment" for commented code
Some of my code is commented without showing the reason.
In this comment, I add the reason for it.

aokblast updated this revision to Diff 554724.Aug 30 2023, 7:46 AM

This change fix the indentation for the ObjectFileELF.cpp

This revision is now accepted and ready to land.Oct 11 2023, 4:26 PM
emaste closed this revision.Oct 11 2023, 4:26 PM