This is an archive of the discontinued LLVM Phabricator instance.

Differential D158885

[CodeGen] Remove unused option in MachineFunctionSplitter.
ClosedPublic

Authored by snehasish on Aug 25 2023, 1:29 PM.

Details

Reviewers
dhoekwater
MaskRay
Commits
rG3dbabeadd63e: [CodeGen] Remove unused option in MachineFunctionSplitter.
Summary

The option was added in github.com/llvm/llvm-project/commit/90ab85a but it doesn't seem to be used. The triple check has been removed so this shouldn't be required going forward.

Diff Detail

Unit TestsFailed

TimeTest
60,040 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

snehasish created this revision.Aug 25 2023, 1:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2023, 1:29 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
snehasish requested review of this revision.Aug 25 2023, 1:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2023, 1:29 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
MaskRay accepted this revision.Aug 25 2023, 2:20 PM
This revision is now accepted and ready to land.Aug 25 2023, 2:20 PM
This revision was landed with ongoing or failed builds.Aug 25 2023, 2:24 PM
Closed by commit rG3dbabeadd63e: [CodeGen] Remove unused option in MachineFunctionSplitter. (authored by snehasish). · Explain Why
This revision was automatically updated to reflect the committed changes.
snehasish added a commit: rG3dbabeadd63e: [CodeGen] Remove unused option in MachineFunctionSplitter..
Harbormaster completed remote builds in B254977: Diff 553594.Aug 25 2023, 4:10 PM

Revision Contents

PathSize
llvm/
lib/
CodeGen/
7 lines
test/
CodeGen/
Generic/
10 lines

Diff 553594

llvm/lib/CodeGen/MachineFunctionSplitter.cpp

Show First 20 Lines • Show All 61 Lines • ▼ Show 20 Lines cl::desc(
"Minimum number of times a block must be executed to be retained."), "Minimum number of times a block must be executed to be retained."),
cl::init(1), cl::Hidden); cl::init(1), cl::Hidden);
static cl::opt<bool> SplitAllEHCode( static cl::opt<bool> SplitAllEHCode(
"mfs-split-ehcode", "mfs-split-ehcode",
cl::desc("Splits all EH code and it's descendants by default."), cl::desc("Splits all EH code and it's descendants by default."),
cl::init(false), cl::Hidden); cl::init(false), cl::Hidden);
static cl::opt<bool> AllowUnsupportedTriple(
"mfs-allow-unsupported-triple",
cl::desc(
"Splits functions even if the target triple isn't supported. This is "
"testing flag for targets that don't yet support function splitting."),
cl::init(false), cl::Hidden);
namespace { namespace {
class MachineFunctionSplitter : public MachineFunctionPass { class MachineFunctionSplitter : public MachineFunctionPass {
public: public:
static char ID; static char ID;
MachineFunctionSplitter() : MachineFunctionPass(ID) { MachineFunctionSplitter() : MachineFunctionPass(ID) {
initializeMachineFunctionSplitterPass(*PassRegistry::getPassRegistry()); initializeMachineFunctionSplitterPass(*PassRegistry::getPassRegistry());
} }
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines

llvm/test/CodeGen/Generic/machine-function-splitter.ll

; REQUIRES: aarch64-registered-target ; REQUIRES: aarch64-registered-target
; REQUIRES: x86-registered-target ; REQUIRES: x86-registered-target
; COM: Machine function splitting with FDO profiles ; COM: Machine function splitting with FDO profiles
; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s -check-prefixes=MFS-DEFAULTS,MFS-DEFAULTS-X86 ; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s -check-prefixes=MFS-DEFAULTS,MFS-DEFAULTS-X86
; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -split-machine-functions -mfs-psi-cutoff=0 -mfs-count-threshold=2000 | FileCheck %s --dump-input=always -check-prefixes=MFS-OPTS1,MFS-OPTS1-X86 ; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -split-machine-functions -mfs-psi-cutoff=0 -mfs-count-threshold=2000 | FileCheck %s --dump-input=always -check-prefixes=MFS-OPTS1,MFS-OPTS1-X86
; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -split-machine-functions -mfs-psi-cutoff=950000 | FileCheck %s -check-prefixes=MFS-OPTS2,MFS-OPTS2-X86 ; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -split-machine-functions -mfs-psi-cutoff=950000 | FileCheck %s -check-prefixes=MFS-OPTS2,MFS-OPTS2-X86
; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -split-machine-functions -mfs-split-ehcode | FileCheck %s -check-prefixes=MFS-EH-SPLIT,MFS-EH-SPLIT-X86 ; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu -split-machine-functions -mfs-split-ehcode | FileCheck %s -check-prefixes=MFS-EH-SPLIT,MFS-EH-SPLIT-X86
; RUN: llc < %s -mtriple=x86_64 -split-machine-functions -O0 -mfs-psi-cutoff=0 -mfs-count-threshold=10000 | FileCheck %s -check-prefixes=MFS-O0,MFS-O0-X86 ; RUN: llc < %s -mtriple=x86_64 -split-machine-functions -O0 -mfs-psi-cutoff=0 -mfs-count-threshold=10000 | FileCheck %s -check-prefixes=MFS-O0,MFS-O0-X86
; RUN: llc < %s -mtriple=aarch64-unknown-linux-gnu -enable-split-machine-functions -mfs-allow-unsupported-triple | FileCheck %s -check-prefixes=MFS-DEFAULTS,MFS-DEFAULTS-AARCH64 ; RUN: llc < %s -mtriple=aarch64-unknown-linux-gnu -enable-split-machine-functions | FileCheck %s -check-prefixes=MFS-DEFAULTS,MFS-DEFAULTS-AARCH64
; RUN: llc < %s -mtriple=aarch64-unknown-linux-gnu -enable-split-machine-functions -mfs-allow-unsupported-triple -mfs-psi-cutoff=0 -mfs-count-threshold=2000 | FileCheck %s --dump-input=always -check-prefixes=MFS-OPTS1,MFS-OPTS1-AARCH64 ; RUN: llc < %s -mtriple=aarch64-unknown-linux-gnu -enable-split-machine-functions -mfs-psi-cutoff=0 -mfs-count-threshold=2000 | FileCheck %s --dump-input=always -check-prefixes=MFS-OPTS1,MFS-OPTS1-AARCH64
; RUN: llc < %s -mtriple=aarch64-unknown-linux-gnu -enable-split-machine-functions -mfs-allow-unsupported-triple -mfs-psi-cutoff=950000 | FileCheck %s -check-prefixes=MFS-OPTS2,MFS-OPTS2-AARCH64 ; RUN: llc < %s -mtriple=aarch64-unknown-linux-gnu -enable-split-machine-functions -mfs-psi-cutoff=950000 | FileCheck %s -check-prefixes=MFS-OPTS2,MFS-OPTS2-AARCH64
; RUN: llc < %s -mtriple=aarch64-unknown-linux-gnu -enable-split-machine-functions -mfs-allow-unsupported-triple -mfs-split-ehcode | FileCheck %s -check-prefixes=MFS-EH-SPLIT,MFS-EH-SPLIT-AARCH64 ; RUN: llc < %s -mtriple=aarch64-unknown-linux-gnu -enable-split-machine-functions -mfs-split-ehcode | FileCheck %s -check-prefixes=MFS-EH-SPLIT,MFS-EH-SPLIT-AARCH64
; RUN: llc < %s -mtriple=aarch64 -enable-split-machine-functions -mfs-allow-unsupported-triple -aarch64-redzone | FileCheck %s -check-prefixes=MFS-REDZONE-AARCH64 ; RUN: llc < %s -mtriple=aarch64 -enable-split-machine-functions -aarch64-redzone | FileCheck %s -check-prefixes=MFS-REDZONE-AARCH64
; COM: Machine function splitting with AFDO profiles ; COM: Machine function splitting with AFDO profiles
; RUN: sed 's/InstrProf/SampleProfile/g' %s > %t.ll ; RUN: sed 's/InstrProf/SampleProfile/g' %s > %t.ll
; RUN: llc < %t.ll -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s --check-prefix=FSAFDO-MFS ; RUN: llc < %t.ll -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s --check-prefix=FSAFDO-MFS
; RUN: llc < %t.ll -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s --check-prefix=FSAFDO-MFS2 ; RUN: llc < %t.ll -mtriple=x86_64-unknown-linux-gnu -split-machine-functions | FileCheck %s --check-prefix=FSAFDO-MFS2
define void @foo1(i1 zeroext %0) nounwind !prof !14 !section_prefix !15 { define void @foo1(i1 zeroext %0) nounwind !prof !14 !section_prefix !15 {
;; Check that cold block is moved to .text.split. ;; Check that cold block is moved to .text.split.
▲ Show 20 Lines • Show All 536 Lines • Show Last 20 Lines