This is an archive of the discontinued LLVM Phabricator instance.

Differential D158860

[libc++][CI] Improves bootstrap build output.
ClosedPublic

Authored by Mordante on Aug 25 2023, 9:41 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG827171398116: [libc++][CI] Improves bootstrap build output.
Summary

Use the same arguments as other builds. This gives better output to
validate what the CI did.

Diff Detail

Event Timeline

Mordante created this revision.Aug 25 2023, 9:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2023, 9:41 AM
Herald added a subscriber: arichardson. · View Herald Transcript
Mordante requested review of this revision.Aug 25 2023, 9:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2023, 9:41 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B254920: Diff 553519.Aug 25 2023, 12:13 PM
Mordante added a child revision: D158878: [runtimes][cmake] Propagate cmake arguments..Aug 25 2023, 12:34 PM
Mordante added inline comments.Aug 29 2023, 11:37 AM
libcxx/utils/ci/run-buildbot
374

Based on D159120 this should be adjusted too.

ldionne accepted this revision.Sep 6 2023, 8:41 AM
ldionne added a subscriber: ldionne.

LGTM w/ your own suggested change.

This revision is now accepted and ready to land.Sep 6 2023, 8:41 AM
Closed by commit rG827171398116: [libc++][CI] Improves bootstrap build output. (authored by Mordante). · Explain WhySep 6 2023, 10:49 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG827171398116: [libc++][CI] Improves bootstrap build output..

Revision Contents

PathSize
libcxx/
utils/
ci/
7 lines

Diff 553519

libcxx/utils/ci/run-buildbot

Show First 20 Lines • Show All 364 Lines • ▼ Show 20 Lines ${CMAKE} \
-DCMAKE_CXX_COMPILER_LAUNCHER="ccache" \ -DCMAKE_CXX_COMPILER_LAUNCHER="ccache" \
-DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}" \ -DCMAKE_INSTALL_PREFIX="${INSTALL_DIR}" \
-DLLVM_ENABLE_PROJECTS="clang" \ -DLLVM_ENABLE_PROJECTS="clang" \
-DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" \ -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind" \
-DLLVM_RUNTIME_TARGETS="$(${CXX} --print-target-triple)" \ -DLLVM_RUNTIME_TARGETS="$(${CXX} --print-target-triple)" \
-DLLVM_TARGETS_TO_BUILD="host" \ -DLLVM_TARGETS_TO_BUILD="host" \
-DRUNTIMES_BUILD_ALLOW_DARWIN=ON \ -DRUNTIMES_BUILD_ALLOW_DARWIN=ON \
-DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_ASSERTIONS=ON \
-DLLVM_LIT_ARGS="-sv --show-unsupported --xunit-xml-output test-results.xml --timeout=1500 --time-tests"
MordanteAuthorUnsubmitted
Done
ReplyInline Actions
-DLLVM_ENABLE_ASSERTIONS=ON \
- -DLLVM_LIT_ARGS="-sv --show-unsupported --xunit-xml-output test-results.xml --timeout=1500 --time-tests"
+ -DLLVM_LIT_ARGS="-v --show-unsupported --xunit-xml-output test-results.xml --timeout=1500 --time-tests"
echo "+++ Running the libc++ and libc++abi tests"

Based on D159120 this should be adjusted too.

Mordante: Based on D159120 this should be adjusted too.
echo "+++ Running the libc++ and libc++abi tests" echo "+++ Running the libc++ and libc++abi tests"
${NINJA} -C "${BUILD_DIR}" check-runtimes ${NINJA} -vC "${BUILD_DIR}" check-runtimes
echo "--- Installing libc++ and libc++abi to a fake location" echo "--- Installing libc++ and libc++abi to a fake location"
${NINJA} -C "${BUILD_DIR}" install-runtimes ${NINJA} -vC "${BUILD_DIR}" install-runtimes
ccache -s ccache -s
;; ;;
generic-static) generic-static)
clean clean
generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-static.cmake" generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/Generic-static.cmake"
check-runtimes check-runtimes
;; ;;
▲ Show 20 Lines • Show All 328 Lines • Show Last 20 Lines