This is an archive of the discontinued LLVM Phabricator instance.

Remove lit's --summary flag from buildbots.
ClosedPublic

Authored by EricWF on Aug 29 2023, 10:03 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG3e0bc8cf78a6: Remove lit's --summary flag from buildbots.
Summary

The summary flag causes a progress bar to appear and be rewritten using
a curses like interface. This works great for interactive sessions, but
produces line after line of garbage in the logs.

This should cause the logs to be much smaller and more readable.

Diff Detail

Event Timeline

EricWF created this revision.Aug 29 2023, 10:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2023, 10:03 AM
Herald added a subscriber: arichardson. · View Herald Transcript
EricWF requested review of this revision.Aug 29 2023, 10:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2023, 10:03 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

I like the idea. I want to have a look once the build https://buildkite.com/llvm-project/phabricator-libcxx-ci/builds/29307 finishes.

ldionne accepted this revision.Aug 31 2023, 7:43 AM

I like this, it makes the logs more readable. The CI failures are flukes on our Windows bots that had a transient issue. Let's ship this!

This revision is now accepted and ready to land.Aug 31 2023, 7:43 AM
This revision was landed with ongoing or failed builds.Aug 31 2023, 11:24 AM
This revision was automatically updated to reflect the committed changes.