This is an archive of the discontinued LLVM Phabricator instance.

[ConstraintElim] fix crash with large constants in mul nsw
ClosedPublic

Authored by erikdesjardins on Aug 24 2023, 9:14 PM.

Details

Summary

Another case of https://github.com/llvm/llvm-project/issues/55085.

The added test would trip an assertion due to calling getSExtValue() on a value that doesn't fit in int64_t.

Diff Detail

Event Timeline

erikdesjardins created this revision.Aug 24 2023, 9:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2023, 9:14 PM
erikdesjardins requested review of this revision.Aug 24 2023, 9:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2023, 9:15 PM
fhahn accepted this revision.Aug 25 2023, 1:03 AM

LGTM, thanks!

This revision is now accepted and ready to land.Aug 25 2023, 1:03 AM
This revision was landed with ongoing or failed builds.Aug 25 2023, 10:20 AM
This revision was automatically updated to reflect the committed changes.
erikdesjardins added inline comments.Aug 25 2023, 2:31 PM
llvm/test/Transforms/ConstraintElimination/large-constant-ints.ll
284

Just realized I forgot to generate checks for this, fixed in https://reviews.llvm.org/rGdf112cba034eefb86d0e92e18518f5e944d58c37