Page MenuHomePhabricator

erikdesjardins (Erik Desjardins)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2021, 9:06 AM (20 w, 3 d)

Recent Activity

Thu, Jan 6

erikdesjardins added a comment to D116628: [X86] add dwarf information for loop stack probe.

Please commit this on my behalf: Erik Desjardins <erikdesjardinspublic@gmail.com>

Thu, Jan 6, 5:27 PM · Restricted Project
erikdesjardins added inline comments to D116628: [X86] add dwarf information for loop stack probe.
Thu, Jan 6, 4:40 PM · Restricted Project
erikdesjardins updated the diff for D116628: [X86] add dwarf information for loop stack probe.

add test demonstrating adjust

Thu, Jan 6, 4:40 PM · Restricted Project

Wed, Jan 5

erikdesjardins updated the diff for D116628: [X86] add dwarf information for loop stack probe.

use alignDown

Wed, Jan 5, 2:25 PM · Restricted Project

Tue, Jan 4

erikdesjardins updated the diff for D116628: [X86] add dwarf information for loop stack probe.

improve description

Tue, Jan 4, 2:31 PM · Restricted Project
erikdesjardins requested review of D116628: [X86] add dwarf information for loop stack probe.
Tue, Jan 4, 2:26 PM · Restricted Project

Mon, Jan 3

erikdesjardins added a comment to D116458: [X86] Improve selection of the mov instruction in FrameLowering.

I don't have commit access, please commit this (and D116420, which autogens the tests) on my behalf (Erik Desjardins <erikdesjardinspublic@gmail.com>).

Mon, Jan 3, 10:31 AM · Restricted Project
erikdesjardins added inline comments to D116458: [X86] Improve selection of the mov instruction in FrameLowering.
Mon, Jan 3, 9:44 AM · Restricted Project
erikdesjardins updated the diff for D116458: [X86] Improve selection of the mov instruction in FrameLowering.

IsLP64 -> Use64BitReg

Mon, Jan 3, 9:44 AM · Restricted Project

Sat, Jan 1

erikdesjardins abandoned D116483: [InstCombine] fold opposite shifts around an add.
Sat, Jan 1, 2:12 PM · Restricted Project
erikdesjardins requested review of D116483: [InstCombine] fold opposite shifts around an add.
Sat, Jan 1, 2:11 PM · Restricted Project
erikdesjardins updated the diff for D116420: [X86] autogen segmented stacks tests (NFC).

.

Sat, Jan 1, 2:11 PM · Restricted Project

Fri, Dec 31

erikdesjardins updated the diff for D116458: [X86] Improve selection of the mov instruction in FrameLowering.

restart build after adding parent rev

Fri, Dec 31, 9:14 AM · Restricted Project
erikdesjardins requested review of D116458: [X86] Improve selection of the mov instruction in FrameLowering.
Fri, Dec 31, 9:12 AM · Restricted Project

Thu, Dec 30

erikdesjardins requested review of D116420: [X86] autogen segmented stacks tests (NFC).
Thu, Dec 30, 11:56 AM · Restricted Project

Nov 24 2021

erikdesjardins added a comment to D114279: [InstSimplify] Fold X {lshr,udiv} C <u X --> true for nonzero X, non-identity C.

I don't have write access, please commit this (and tests in parent revision https://reviews.llvm.org/D114280) on my behalf: Erik Desjardins <erikdesjardinspublic@gmail.com>

Nov 24 2021, 2:09 PM · Restricted Project
erikdesjardins updated the diff for D114279: [InstSimplify] Fold X {lshr,udiv} C <u X --> true for nonzero X, non-identity C.

use >>u to make shift type explicit

Nov 24 2021, 2:08 PM · Restricted Project

Nov 23 2021

erikdesjardins added inline comments to D114279: [InstSimplify] Fold X {lshr,udiv} C <u X --> true for nonzero X, non-identity C.
Nov 23 2021, 4:45 PM · Restricted Project
erikdesjardins updated the diff for D114279: [InstSimplify] Fold X {lshr,udiv} C <u X --> true for nonzero X, non-identity C.

make comments more explicit about matched patterns
use more general C != 0 and C != 1 instead of C >u 0 and C >u 1 respectively

Nov 23 2021, 4:40 PM · Restricted Project
erikdesjardins updated the diff for D114280: [InstSimplify] precommit tests for icmp of lshr/udiv fold (NFC).

improve test naming, add negative tests for a signed pred

Nov 23 2021, 4:37 PM · Restricted Project

Nov 19 2021

erikdesjardins updated the diff for D114279: [InstSimplify] Fold X {lshr,udiv} C <u X --> true for nonzero X, non-identity C.

tweak summary formatting

Nov 19 2021, 1:28 PM · Restricted Project
erikdesjardins updated the diff for D114280: [InstSimplify] precommit tests for icmp of lshr/udiv fold (NFC).

actually update description

Nov 19 2021, 1:24 PM · Restricted Project
erikdesjardins updated the diff for D114280: [InstSimplify] precommit tests for icmp of lshr/udiv fold (NFC).

link orig diff

Nov 19 2021, 1:22 PM · Restricted Project
erikdesjardins requested review of D114280: [InstSimplify] precommit tests for icmp of lshr/udiv fold (NFC).
Nov 19 2021, 1:21 PM · Restricted Project
erikdesjardins requested review of D114279: [InstSimplify] Fold X {lshr,udiv} C <u X --> true for nonzero X, non-identity C.
Nov 19 2021, 1:20 PM · Restricted Project

Oct 6 2021

erikdesjardins added a comment to D109294: [Inline] Introduce Constant::hasOneLiveUse, use it instead of hasOneUse in inline cost model (PR51667).

I don't have commit access--please commit this on my behalf (Erik Desjardins <erikdesjardinspublic@gmail.com>)

Oct 6 2021, 7:54 PM · Restricted Project

Oct 5 2021

erikdesjardins updated the diff for D109294: [Inline] Introduce Constant::hasOneLiveUse, use it instead of hasOneUse in inline cost model (PR51667).

remove unused functions, unify constantIsDead/removeDeadUsersOfConstant

Oct 5 2021, 6:11 PM · Restricted Project
erikdesjardins updated the diff for D109294: [Inline] Introduce Constant::hasOneLiveUse, use it instead of hasOneUse in inline cost model (PR51667).

clang-format

Oct 5 2021, 7:17 AM · Restricted Project

Oct 4 2021

erikdesjardins updated the diff for D109294: [Inline] Introduce Constant::hasOneLiveUse, use it instead of hasOneUse in inline cost model (PR51667).

switch to hasOneLiveUse

Oct 4 2021, 9:08 PM · Restricted Project

Sep 11 2021

erikdesjardins added a comment to D109294: [Inline] Introduce Constant::hasOneLiveUse, use it instead of hasOneUse in inline cost model (PR51667).

Looking at usages of removeDeadConstantUsers() in other passes...

Sep 11 2021, 9:11 AM · Restricted Project

Sep 9 2021

erikdesjardins added a comment to D109294: [Inline] Introduce Constant::hasOneLiveUse, use it instead of hasOneUse in inline cost model (PR51667).

I don't have commit rights--please commit this as Erik Desjardins <erikdesjardinspublic@gmail.com>

Sep 9 2021, 5:57 PM · Restricted Project

Sep 7 2021

erikdesjardins added inline comments to D109294: [Inline] Introduce Constant::hasOneLiveUse, use it instead of hasOneUse in inline cost model (PR51667).
Sep 7 2021, 7:01 PM · Restricted Project
erikdesjardins updated the diff for D109294: [Inline] Introduce Constant::hasOneLiveUse, use it instead of hasOneUse in inline cost model (PR51667).

move out of analysis; make test less fragile

Sep 7 2021, 6:59 PM · Restricted Project

Sep 5 2021

erikdesjardins added inline comments to D109294: [Inline] Introduce Constant::hasOneLiveUse, use it instead of hasOneUse in inline cost model (PR51667).
Sep 5 2021, 1:12 PM · Restricted Project
erikdesjardins updated the diff for D109294: [Inline] Introduce Constant::hasOneLiveUse, use it instead of hasOneUse in inline cost model (PR51667).

Preserve the spirit of last-callsite.ll test

Sep 5 2021, 1:12 PM · Restricted Project
erikdesjardins requested review of D109294: [Inline] Introduce Constant::hasOneLiveUse, use it instead of hasOneUse in inline cost model (PR51667).
Sep 5 2021, 9:57 AM · Restricted Project