Implement LWG3464 https://wg21.link/LWG3464
ldionne Mordante philnik
- Group Reviewers
- rG06ef752b7c23: [libc++] Implement LWG3464(istream::gcount() can overflow)
rGd57fe1dbe050: [libc++] Implement LWG3464(istream::gcount() can overflow)
Please use my suggestion, that matches our latest coding standard.
Nit: I prefer to have private, protected, public in that order, especially since there is already a private section.
Sorry, It may be because I didn't refresh the browser page, so I didn't see the status change to Request change. I apologize for that. I'll revert this change to resolve your concerns. I have no idea that how to test this, can you please give some guide? many thanks!
Ah sorry, I missed that. I though it depends the char traits. In that case I'm happy with a short explanation in the commit message. Sorry for the churn.
LGTM with a comment in the commit message.