This is an archive of the discontinued LLVM Phabricator instance.

[libc] Fix fputil::multiply_add and fputil::polyeval template signatures.
ClosedPublic

Authored by lntue on Aug 24 2023, 8:52 AM.

Details

Summary

Fix fputil::multiply_add and fputil::polyeval template function
signatures.

Diff Detail

Event Timeline

lntue created this revision.Aug 24 2023, 8:52 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 24 2023, 8:52 AM
lntue requested review of this revision.Aug 24 2023, 8:52 AM
lntue edited the summary of this revision. (Show Details)Aug 24 2023, 8:58 AM
lntue added a reviewer: jhuber6.
sivachandra accepted this revision.Aug 24 2023, 9:00 AM

If you can add some inline commentary about how it affects volatile args, that will be even more helpful.

This revision is now accepted and ready to land.Aug 24 2023, 9:00 AM
jhuber6 added inline comments.Aug 24 2023, 9:00 AM
libc/src/__support/FPUtil/PolyEval.h
41

Isn't this more standard?

This revision was landed with ongoing or failed builds.Aug 24 2023, 9:01 AM
This revision was automatically updated to reflect the committed changes.