This is an archive of the discontinued LLVM Phabricator instance.

Differential D158703

[llvm-cov] Enable `-show-directory-coverage` for LLVM itself.
ClosedPublic

Authored by AtomicGu on Aug 23 2023, 10:07 PM.

Details

Reviewers
phosek
gulfem
davidxl
Commits
rG64425caba29e: [llvm-cov] Enable `-show-directory-coverage` for LLVM itself.
Summary

My previous patch D151283 added a new option to llvm-cov to make it generate a hierarchical report for better view. This patch is to enable it for the coverage report of LLVM itself.

Diff Detail

Event Timeline

AtomicGu created this revision.Aug 23 2023, 10:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 10:07 PM
AtomicGu requested review of this revision.Aug 23 2023, 10:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 10:07 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
AtomicGu added a parent revision: D151283: [llvm-cov] Support directory layout in coverage reports.Aug 23 2023, 10:08 PM
Harbormaster completed remote builds in B254537: Diff 552988.Aug 23 2023, 11:40 PM
phosek accepted this revision.Aug 24 2023, 12:24 AM

LGTM

This revision is now accepted and ready to land.Aug 24 2023, 12:24 AM
This revision was landed with ongoing or failed builds.Aug 24 2023, 5:26 AM
Closed by commit rG64425caba29e: [llvm-cov] Enable `-show-directory-coverage` for LLVM itself. (authored by AtomicGu). · Explain Why
This revision was automatically updated to reflect the committed changes.
AtomicGu added a commit: rG64425caba29e: [llvm-cov] Enable `-show-directory-coverage` for LLVM itself..
gulfem mentioned this in D159469: [jenkins] Coverage bot: Remove cross-project-tests.Sep 6 2023, 11:13 AM
gulfem mentioned this in rZORGe606847405cb: [jenkins] Coverage bot: Remove cross-project-tests.Sep 8 2023, 4:00 PM

Revision Contents

PathSize
llvm/
utils/
1 line

Diff 553083

llvm/utils/prepare-code-coverage-artifact.py

Show First 20 Lines • Show All 61 Lines • ▼ Show 20 Lines invocation = (
+ [ + [
"-format", "-format",
"html", "html",
"-instr-profile", "-instr-profile",
profile, profile,
"-o", "-o",
report_dir, report_dir,
"-show-line-counts-or-regions", "-show-line-counts-or-regions",
"-show-directory-coverage",
"-Xdemangler", "-Xdemangler",
"c++filt", "c++filt",
"-Xdemangler", "-Xdemangler",
"-n", "-n",
] ]
+ restricted_dirs + restricted_dirs
) )
if compilation_dir: if compilation_dir:
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines