This is an archive of the discontinued LLVM Phabricator instance.

To allow RAV to visit initializer when bitfield and initializer both given
Needs ReviewPublic

Authored by NoumanAmir657 on Aug 23 2023, 7:16 AM.

Details

Summary

The RAV does not visit the initializer when the bitfield is given because it uses if-else statement. Code was changed to two seperate ifs so that it can visit both of them if both are present.

Diff Detail

Event Timeline

NoumanAmir657 created this revision.Aug 23 2023, 7:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 7:16 AM
NoumanAmir657 requested review of this revision.Aug 23 2023, 7:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 7:16 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Eugene.Zelenko edited reviewers, added: Fznamznon; removed: Eugene.Zelenko.Aug 23 2023, 7:24 AM

This needs a test and a release note, and it failed pre-commit CI. I don't have a good idea how to test this however, there is perhaps one of the visitor unit tests that can show this off?

The pre-commit checks passed now when I built again. Looking into test for this now