This is an archive of the discontinued LLVM Phabricator instance.

[Lex] Handle repl_input_end in Preprocessor::LexTokensUntilEOF()
ClosedPublic

Authored by Hahnfeld on Aug 21 2023, 5:09 AM.

Details

Summary

This fixes many unit tests when trying to enable IncrementalExtensions by default for testing purposes.

Diff Detail

Event Timeline

Hahnfeld created this revision.Aug 21 2023, 5:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2023, 5:09 AM
Hahnfeld requested review of this revision.Aug 21 2023, 5:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2023, 5:09 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
v.g.vassilev accepted this revision.Sep 4 2023, 12:24 PM

Looks reasonable to me.

This revision is now accepted and ready to land.Sep 4 2023, 12:24 PM

@Hahnfeld, let's move forward and rely on a post-commit review here.

This revision cannot land without https://reviews.llvm.org/D158413 and for that one I really want to have feedback from somebody working in that area...

aaron.ballman accepted this revision.Sep 14 2023, 6:01 AM

The idea LGTM when D158413 lands, even if that lands with a slightly different design. (IOW, once D158413 lands, feel free to push this change without further review unless you would like more feedback.)

Hahnfeld updated this revision to Diff 556849.Sep 15 2023, 5:33 AM
Hahnfeld retitled this revision from [Lex] Handle repl_input_end in Preprocessor::LexAll() to [Lex] Handle repl_input_end in Preprocessor::LexTokensUntilEOF().

Rebase on D158413