[Fortran] Add missing unsupported LLVM Flang options

[awarzynski]

Summary

See the following patches in LLVM Flang for context:

• https://reviews.llvm.org/D157837
• https://reviews.llvm.org/D158307

[tarunprabhu]

CMakeLists.txt

61

Can this be replaced with add_compile_options? If so, we might as well do it now.

61–62

If these are tabs, could you replace them with spaces.

Fortran/gfortran/CMakeLists.txt

526

Is this intentional? Many of the compile tests pass specific flags to the compiler, so this message will only really refer to the common set of flags.

[awarzynski]

Remove accidental message()

[awarzynski]

Thanks for taking a look!

CMakeLists.txt

61

Can this be replaced with add_compile_options?

Possbily, but there are places in CMake scripts that assume that this is how -w has been added. It all looks a bit fragile to me.

If so, we might as well do it now.

Please, can we stick to 1 change per patch? This would be tangential to what I am trying to achieve here.

61–62

These are not tabs. This is how Phabricator displays new level of indentation (i.e. new spaces)

Fortran/gfortran/CMakeLists.txt

526

No, sorry about that, was meant to remove it before sending for review.

[tarunprabhu]

OK. Thanks for the changes and clarifications.

CMakeLists.txt

61

Ok.

CMakeLists.txt

 set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${TEST_SUITE_ARCH_FLAGS}")
 
 set(LLVM_CODESIGNING_IDENTITY "" CACHE STRING
   "Sign executables and dylibs with the given identity or skip if empty (Darwin Only)")
 
 add_definitions(-DNDEBUG)
 option(TEST_SUITE_SUPPRESS_WARNINGS "Suppress all warnings" ON)
 if(${TEST_SUITE_SUPPRESS_WARNINGS})
+  if(NOT CMAKE_Fortran_COMPILER_ID STREQUAL "LLVMFlang")
+    # NOTE: ATM (18/8/23) LLVM Flang does not support the -w flag.
+    # FIXME: Don't use add_definitions to add compiler flags
     add_definitions(-w)
   endif()
+endif()
 
 # We want reproducible builds, so using __DATE__ and __TIME__ is bad
 # FIXME: Add this unconditionally when flang starts supporting it.
 if(NOT CMAKE_Fortran_COMPILER_ID STREQUAL "LLVMFlang")
   add_definitions(-Werror=date-time)
 endif()
 
 # Add path for custom modules

Fortran/gfortran/CMakeLists.txt

 # be provided explicitly.
 set(TEST_SUITE_FORTRAN_ISO_C_HEADER_DIR "" CACHE STRING
   "Path to the directory containing ISO_Fortran_bindings.h header file.")
 
 # The following cause errors if they are passed to flang via FFLAGS. This could
 # be because they are currently unsupported and might eventually be supported
 # or because they are GCC-specific and will never be supported.
 set(FLANG_ERRORING_FFLAGS
+  max-completely-peel-loop-nest-depth=1
   -fallow-invalid-boz
+  -fcheck-array-temporaries
+  -fcheck=bounds
+  -fcheck=do
+  -fcheck=recursion
+  -fcoarray=lib
   -fdec
   -fdec-format-defaults
   -fdec-static
   -fdec-structure
+  -frecord-marker=4
+  -fbounds-check
+  -fcheck-bounds
+  -fcheck=all
+  -fcheck=bits
   # Not sure if the -fdefault-* options will be supported. Maybe in a different
   # form in which case, this will have to be modified to accommodate those.
   -fdefault-real-10
   -fdefault-real-16
   -fdump-ipa-cp-details
   -fdump-ipa-fnsummary-details
   -fdump-ipa-inline-details
   -fdump-rtl-expand
   -fdump-tree-all
   -fdump-tree-cunroll-details
   -fdump-tree-cunrolli-details
   -fdump-tree-fre1
   -fdump-tree-gimple
   -fdump-tree-ifcvt
   -fdump-tree-lversion-details
   -fdump-tree-omplower
   -fdump-tree-optimized
   -fdump-tree-original
   -fdump-tree-pcom-details
   -fdump-tree-pre-details
   -fdump-tree-profile-estimate
   -fdump-tree-reassoc1
   -fdump-tree-vect-details
+  -fexpensive-optimizations
   -ff2c
+  -ffree-line-length-none
+  -ffrontend-optimize
+  -fgcse
   -finline-matmul-limit=0
   -finline-matmul-limit=10
   -finline-matmul-limit=100
   -finline-matmul-limit=1000
   -finline-matmul-limit=2
   -finline-matmul-limit=30
   -fipa-cp
   -fipa-cp-clone
   -fipa-pta
   -fipa-reference
+  -fmodulo-sched
+  -fno-align-commons
+  -fno-asynchronous-unwind-tables
+  -fno-backtrace
+  -fno-bounds-check
+  -fno-check-array-temporaries
   -fno-dec
+  -fno-f2c
+  -fno-frontend-optimize
   -fno-guess-branch-probability
+  -fno-inline
   -fno-ipa-cp
   -fno-ipa-modref
   -fno-ipa-sra
   -fno-pad-source
+  -fno-range-check
+  -fno-realloc-lhs
+  -fno-sign-zero
   -fno-tree-ccp
   -fno-tree-forwprop
   -fno-tree-fre
   -fno-tree-loop-optimize
   -fno-tree-loop-vectorize
   -fpad-source
+  -fpeel-loops
+  -frecursive
+  -fsanitize=undefined
   -fset-g77-defaults
+  -fshort-enums
   -ftest-forall-temp
   -ftree-loop-distribution
   -ftree-loop-vectorize
   -ftree-pre
   -ftree-slp-vectorize
   -ftree-tail-merge
   -ftree-vectorize
   -ftree-vrp
+  -funroll-loops
+  -fwrapv
   -mdalign
   -mdejagnu-cpu=power4
   -mfpmath=387
   -mfpmath=sse
   -mtune=amdfam10
   # -Os might eventually be supported, so this might also need to be removed
   # at some point
   -Og
   -Os
   # At some point, if we ever support explicit standard flags, some of these
   # should be removed.
+  -pedantic-errors
   -std=gnu
   -std=legacy
   -std=f95
   -std=f2003
   -std=f2008
   -std=f2008ts
   # At the time of writing, -W warnings are not supported. flang errors out
   # saying that only -Werror is supported.
set(FLANG_ERRORING_FFLAGS
   -Wtabs
   -Wuninitialized
   -Wunused
   -Wunused-dummy-argument
   -Wunused-function
   -Wunused-parameter
   -Wunused-variable
   -Wzerotrip
+  -w
+  --param
 )
 
 # Find all the Fortran files in the current source directory that may be test
 # files. This will filter out those files that have been explicitly disabled
 # for any reason. The returned files will be consist of the main file for
 # "execute" and "compile" tests as well as any dependencies for multi-file
 # tests.
 function(gfortran_find_test_files unsupported unimplemented skipped failing out)
function(gfortran_add_compile_tests tests)
   cmake_parse_arguments(GFORTRAN "" "" "FFLAGS;LDFLAGS" ${ARGN})
 
   list(APPEND fflags ${GFORTRAN_FFLAGS})
   list(APPEND ldflags ${GFORTRAN_LDFLAGS})
 
   foreach (file ${tests})
     gfortran_add_compile_test(OFF ${file} "" "${fflags}" "${ldflags}")
   endforeach()
 endfunction()
 
 # Setup an "execute" test. In the case of multi-file tests, MAIN will be the
 # main file. For multi-file tests, OTHERS will be the remaining files needed by
 # the test. FFLAGS are additional compiler flags needed by the test. LDFLAGS
 # are the other linker flags needed by the test.
 function(gfortran_add_execute_test main others fflags ldflags)
   # PREFIX_EXECUTE will have been defined in the subdirectory from which this
   # function is called.