This is an archive of the discontinued LLVM Phabricator instance.

Differential D158290

[emacs] Highlight hexadecimal integer constants
ClosedPublic

Authored by luke on Aug 18 2023, 8:44 AM.

Details

Reviewers
goldstein.w.n
Commits
rG160ab99539a1: [emacs] Highlight hexadecimal integer constants
Summary

Today I learnt about their existence (D158288), they just need to be prefixed
with a u or s.

Diff Detail

Event Timeline

luke created this revision.Aug 18 2023, 8:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2023, 8:44 AM
Herald added subscribers: asb, pmatos. · View Herald Transcript
luke requested review of this revision.Aug 18 2023, 8:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2023, 8:44 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B253511: Diff 551532.Aug 18 2023, 10:20 AM
goldstein.w.n accepted this revision.Aug 18 2023, 10:39 AM

LGTM.

This revision is now accepted and ready to land.Aug 18 2023, 10:39 AM
Closed by commit rG160ab99539a1: [emacs] Highlight hexadecimal integer constants (authored by luke). · Explain WhyAug 18 2023, 11:54 AM
This revision was automatically updated to reflect the committed changes.
luke added a commit: rG160ab99539a1: [emacs] Highlight hexadecimal integer constants.

Revision Contents

PathSize
llvm/
utils/
emacs/
2 lines

Diff 551532

llvm/utils/emacs/llvm-mode.el

Show All 37 Lines(defvar llvm-font-lock-keywords
`(,(regexp-opt `(,(regexp-opt
'("void" "i1" "i8" "i16" "i32" "i64" "i128" "half" "bfloat" "float" "double" "fp128" "x86_fp80" "ppc_fp128" "x86_mmx" "x86_amx" "ptr" '("void" "i1" "i8" "i16" "i32" "i64" "i128" "half" "bfloat" "float" "double" "fp128" "x86_fp80" "ppc_fp128" "x86_mmx" "x86_amx" "ptr"
"type" "label" "opaque" "token") 'symbols) . font-lock-type-face) "type" "label" "opaque" "token") 'symbols) . font-lock-type-face)
;; Integer literals ;; Integer literals
'("\\b[-]?[0-9]+\\b" . font-lock-preprocessor-face) '("\\b[-]?[0-9]+\\b" . font-lock-preprocessor-face)
;; Floating point constants ;; Floating point constants
'("\\b[-+]?[0-9]+.[0-9]*\\([eE][-+]?[0-9]+\\)?\\b" . font-lock-preprocessor-face) '("\\b[-+]?[0-9]+.[0-9]*\\([eE][-+]?[0-9]+\\)?\\b" . font-lock-preprocessor-face)
;; Hex constants ;; Hex constants
'("\\b0x[0-9A-Fa-f]+\\b" . font-lock-preprocessor-face) '("\\b[us]?0x[0-9A-Fa-f]+\\b" . font-lock-preprocessor-face)
;; Keywords ;; Keywords
`(,(regexp-opt `(,(regexp-opt
'(;; Toplevel entities '(;; Toplevel entities
"declare" "define" "module" "target" "source_filename" "global" "constant" "const" "alias" "ifunc" "comdat" "declare" "define" "module" "target" "source_filename" "global" "constant" "const" "alias" "ifunc" "comdat"
"attributes" "uselistorder" "uselistorder_bb" "attributes" "uselistorder" "uselistorder_bb"
;; Linkage types ;; Linkage types
"private" "internal" "weak" "weak_odr" "linkonce" "linkonce_odr" "available_externally" "appending" "common" "extern_weak" "external" "private" "internal" "weak" "weak_odr" "linkonce" "linkonce_odr" "available_externally" "appending" "common" "extern_weak" "external"
"uninitialized" "implementation" "..." "uninitialized" "implementation" "..."
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines