This is an archive of the discontinued LLVM Phabricator instance.

[llvm][github] Allow `/` in branches name in the `/branch` command
AbandonedPublic

Authored by cor3ntin on Aug 18 2023, 6:31 AM.

Details

Reviewers
thieta
tstellar
Summary

IE cor3ntin/llvm-project/cor3ntin/foo

Diff Detail

Event Timeline

cor3ntin created this revision.Aug 18 2023, 6:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2023, 6:31 AM
cor3ntin requested review of this revision.Aug 18 2023, 6:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2023, 6:31 AM
cor3ntin abandoned this revision.Aug 18 2023, 6:46 AM
aaron.ballman added a subscriber: aaron.ballman.

FWIW, I ran into this today with an attempt to backport https://github.com/llvm/llvm-project/issues/64713, so I'm in favor of the changes. It'd also be nice if we could silently accept // cherry-pick: and // branch: (with a colon) because I managed to mess that up as well. :-D

After thinking about it, I don't think this fix make sense.
foo/bar:foo/bar should be a valid refspec.
I also validated that the /branch regex seem correct. So... not sure what the issue is. Sorry for creating that too quick!