This is an archive of the discontinued LLVM Phabricator instance.

Differential D158230

[libc++][NFC] Remove some dead code
ClosedPublic

Authored by philnik on Aug 17 2023, 3:55 PM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG22347afb724c: [libc++][NFC] Remove some dead code
Summary

We only support Clang on windows, so this code path is never taken.

Diff Detail

Event Timeline

philnik created this revision.Aug 17 2023, 3:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2023, 3:55 PM
philnik requested review of this revision.Aug 17 2023, 3:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2023, 3:55 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B253340: Diff 551310.Aug 18 2023, 1:47 AM
Mordante accepted this revision.Aug 23 2023, 9:24 AM
Mordante added a subscriber: Mordante.

LGTM since the CI is happy too.

This revision is now accepted and ready to land.Aug 23 2023, 9:24 AM
Closed by commit rG22347afb724c: [libc++][NFC] Remove some dead code (authored by philnik). · Explain WhyAug 30 2023, 9:07 PM
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG22347afb724c: [libc++][NFC] Remove some dead code.

Revision Contents

PathSize
libcxx/
include/
6 lines

Diff 551310

libcxx/include/__config

// -*- C++ -*- // -*- C++ -*-
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef _LIBCPP___CONFIG #ifndef _LIBCPP___CONFIG
#define _LIBCPP___CONFIG #define _LIBCPP___CONFIG
#include <__config_site> #include <__config_site>
#if defined(_MSC_VER) && !defined(__clang__)
# if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# define _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER
# endif
#endif
#ifndef _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER #ifndef _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER
# pragma GCC system_header # pragma GCC system_header
#endif #endif
#if defined(__apple_build_version__) #if defined(__apple_build_version__)
// Given AppleClang XX.Y.Z, _LIBCPP_APPLE_CLANG_VER is XXYZ (e.g. AppleClang 14.0.3 => 1403) // Given AppleClang XX.Y.Z, _LIBCPP_APPLE_CLANG_VER is XXYZ (e.g. AppleClang 14.0.3 => 1403)
# define _LIBCPP_COMPILER_CLANG_BASED # define _LIBCPP_COMPILER_CLANG_BASED
# define _LIBCPP_APPLE_CLANG_VER (__apple_build_version__ / 10000) # define _LIBCPP_APPLE_CLANG_VER (__apple_build_version__ / 10000)
▲ Show 20 Lines • Show All 1,454 Lines • Show Last 20 Lines