This is an archive of the discontinued LLVM Phabricator instance.

Differential D158224

[mlir] Unneeded exports were added to the float utils
AbandonedPublic

Authored by rsuderman on Aug 17 2023, 3:12 PM.

Details

Reviewers
NatashaKnk
Summary

These exports were not needed for the float utils and caused
a collision on windows.

Diff Detail

Event Timeline

rsuderman created this revision.Aug 17 2023, 3:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2023, 3:12 PM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 21 others. · View Herald Transcript
rsuderman requested review of this revision.Aug 17 2023, 3:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2023, 3:12 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rsuderman added a reviewer: NatashaKnk.Aug 17 2023, 3:13 PM
NatashaKnk accepted this revision.Aug 17 2023, 3:15 PM
This revision is now accepted and ready to land.Aug 17 2023, 3:15 PM
Harbormaster completed remote builds in B253328: Diff 551290.Aug 17 2023, 3:52 PM
rsuderman abandoned this revision.Aug 17 2023, 4:50 PM

Revision Contents

PathSize
mlir/
include/
mlir/
ExecutionEngine/
3 lines

Diff 551290

mlir/include/mlir/ExecutionEngine/Float16bits.h

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
}; };
} }
// Outputs a half precision value. // Outputs a half precision value.
MLIR_FLOAT16_EXPORT std::ostream &operator<<(std::ostream &os, const f16 &f); MLIR_FLOAT16_EXPORT std::ostream &operator<<(std::ostream &os, const f16 &f);
// Outputs a bfloat value. // Outputs a bfloat value.
MLIR_FLOAT16_EXPORT std::ostream &operator<<(std::ostream &os, const bf16 &d); MLIR_FLOAT16_EXPORT std::ostream &operator<<(std::ostream &os, const bf16 &d);
extern "C" MLIR_FLOAT16_EXPORT void printF16(uint16_t bits);
extern "C" MLIR_FLOAT16_EXPORT void printBF16(uint16_t bits);
#undef MLIR_FLOAT16_EXPORT #undef MLIR_FLOAT16_EXPORT
#endif // MLIR_EXECUTIONENGINE_FLOAT16BITS_H_ #endif // MLIR_EXECUTIONENGINE_FLOAT16BITS_H_