This is an archive of the discontinued LLVM Phabricator instance.

[libc++][modules] Generates std.cppm.in.
ClosedPublic

Authored by Mordante on Aug 17 2023, 8:55 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG41161aeb5460: [libc++][modules] Generates std.cppm.in.
Summary

This takes the header restrictions into account instead of manually
duplicating this build information. This is a preparation to properly
support the libc++ disabled parts in the std module.

Diff Detail

Event Timeline

Mordante created this revision.Aug 17 2023, 8:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2023, 8:55 AM
Herald added a subscriber: arichardson. · View Herald Transcript
Mordante updated this revision to Diff 551713.Aug 19 2023, 12:03 AM

Reworked the patch based on upstream changes and add to patch stack.

Mordante published this revision for review.Aug 19 2023, 4:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2023, 4:36 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Aug 22 2023, 10:00 AM
ldionne added a subscriber: ldionne.
ldionne added inline comments.
libcxx/modules/std.cppm.in
1

Commit typo: instead of manually duplication => instead of manually duplicating

libcxx/utils/libcxx/header_information.py
153–156
195
200
This revision is now accepted and ready to land.Aug 22 2023, 10:00 AM
Mordante edited the summary of this revision. (Show Details)Aug 22 2023, 11:10 AM
Mordante marked 4 inline comments as done.
This revision was automatically updated to reflect the committed changes.