This is an archive of the discontinued LLVM Phabricator instance.

[libc++][CI] Switches to CMake 3.27.
AbandonedPublic

Authored by Mordante on Jun 26 2023, 8:17 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This validates all jobs work properly. This is a preparation to make
3.27 the default CMake version.

Depends on D153408

Diff Detail

Event Timeline

Mordante created this revision.Jun 26 2023, 8:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2023, 8:17 AM
Herald added a subscriber: arichardson. · View Herald Transcript
Mordante requested review of this revision.Jun 26 2023, 8:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2023, 8:17 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne added a subscriber: ldionne.Jul 4 2023, 1:10 PM
ldionne added inline comments.
libcxx/utils/ci/buildkite-pipeline.yml
37

Do you plan on reverting this patch once CMake 3.27 is the default in the CI? If so, is there a reason why we don't simply bump the default version in our Docker image now that we've validated it would work, and then abandon this patch?

Mordante added inline comments.Jul 5 2023, 8:58 AM
libcxx/utils/ci/buildkite-pipeline.yml
37

The main reason not to do it is that this will break the LLVM-16 release branch. So I planned to revert this shortly before LLVM-17 is branched. I can also wait a few weeks and do it directly in main. At least we know the entire CI works CMake 3.27.

ldionne added inline comments.Jul 11 2023, 10:54 AM
libcxx/utils/ci/buildkite-pipeline.yml
37

I think I would wait for LLVM 17 to branch, and then I would bump the whole CI to CMake 3.27 in the Docker image unconditionally.

Mordante abandoned this revision.Aug 31 2023, 10:55 AM

This will need significant rework so move to GH for now.