[lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported

[Michael137]

Summary

The ASTImporter::Imported base method has been made a no-op in
26f72a96559f2acd6799c363f1ca88ef3238c601. So all calls to it from
a base-class are now redundant. The API is now only used to notify
subclasses that an import occurred and not for any other
bookkeeping (which is done in MapImported which we call properly)

[Michael137]

• Reword commit message

lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp

void ClangASTImporter::ASTImporterDelegate::ImportDefinitionTo(
   // We might have a forward declaration from a shared library that we
   // gave external lexical storage so that Clang asks us about the full
   // definition when it needs it. In this case the ASTImporter isn't aware
   // that the forward decl from the shared library is the actual import
   // target but would create a second declaration that would then be defined.
   // We want that 'to' is actually complete after this function so let's
   // tell the ASTImporter that 'to' was imported from 'from'.
   MapImported(from, to);
-  ASTImporter::Imported(from, to);
 
   Log *log = GetLog(LLDBLog::Expressions);
 
   if (llvm::Error err = ImportDefinition(from)) {
     LLDB_LOG_ERROR(log, std::move(err),
                    "[ClangASTImporter] Error during importing definition: {0}");
     return;
   }

 
 void ClangASTImporter::ASTImporterDelegate::Imported(clang::Decl *from,
                                                      clang::Decl *to) {
   Log *log = GetLog(LLDBLog::Expressions);
 
   // Some decls shouldn't be tracked here because they were not created by
   // copying 'from' to 'to'. Just exit early for those.
   if (m_decls_to_ignore.count(to))
-    return clang::ASTImporter::Imported(from, to);
+    return;
 
   // Transfer module ownership information.
   auto *from_source = llvm::dyn_cast_or_null<ClangExternalASTSourceCallbacks>(
       getFromContext().getExternalSource());
   // Can also be a ClangASTSourceProxy.
   auto *to_source = llvm::dyn_cast_or_null<ClangExternalASTSourceCallbacks>(
       getToContext().getExternalSource());
   if (from_source && to_source) {
void ClangASTImporter::ASTImporterDelegate::Imported(clang::Decl *from,
   if (from_context_md) {
     DeclOrigin origin = from_context_md->getOrigin(from);
 
     if (origin.Valid()) {
       if (origin.ctx != &to->getASTContext()) {
         if (!to_context_md->hasOrigin(to) || user_id != LLDB_INVALID_UID)
           to_context_md->setOrigin(to, origin);
 
-        ImporterDelegateSP direct_completer =
-            m_main.GetDelegate(&to->getASTContext(), origin.ctx);
-
-        if (direct_completer.get() != this)
-          direct_completer->ASTImporter::Imported(origin.decl, to);
-
         LLDB_LOG(log,
                  "    [ClangASTImporter] Propagated origin "
                  "(Decl*){0}/(ASTContext*){1} from (ASTContext*){2} to "
                  "(ASTContext*){3}",
                  origin.decl, origin.ctx, &from->getASTContext(),
                  &to->getASTContext());
       }
     } else {