[analyzer] Handle another Android assert function.

[ygribov]

Summary

Android's assert can call both assert and assert2 functions under the cover but NoReturn does not handle the latter. This patch fixes this.

[ygribov]

Relevant snippet from bionic/libc/include/assert.h:

# if __ISO_C_VISIBLE >= 1999
#  define       assert(e)       ((e) ? (void)0 : __assert2(__FILE__, __LINE__, __func__, #e))
...
__dead void __assert2(const char *, int, const char *, const char *);

[dcoughlin]

Thanks Yuri! This looks great. Can you also add a test to tests/analysis/NoReturn.m for this? You can follow the example of test_wassert there.

[ygribov]

Added a test.

cfe/trunk/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp

if (const IdentifierInfo *II = CE.getCalleeIdentifier()) {
             .Case("error", true)
             .Case("Assert", true)
             // FIXME: This is just a wrapper around throwing an exception.
             //  Eventually inter-procedural analysis should handle this easily.
             .Case("ziperr", true)
             .Case("assfail", true)
             .Case("db_error", true)
             .Case("__assert", true)
+            .Case("__assert2", true)
             // For the purpose of static analysis, we do not care that
             //  this MSVC function will return if the user decides to continue.
             .Case("_wassert", true)
             .Case("__assert_rtn", true)
             .Case("__assert_fail", true)
             .Case("dtrace_assfail", true)
             .Case("yy_fatal_error", true)
             .Case("_XCAssertionFailureHandler", true)

cfe/trunk/test/Analysis/NoReturn.m

 // Test that hard-coded Microsoft _wassert name is recognized as a noreturn
 #define assert(_Expression) (void)( (!!(_Expression)) || (_wassert(#_Expression, __FILE__, __LINE__), 0) )
 extern void _wassert(const char * _Message, const char *_File, unsigned _Line);
 void test_wassert() {
   assert(0);
   int *p = 0;
   *p = 0xDEADBEEF; // no-warning
 }
+#undef assert
+
+// Test that hard-coded Android __assert2 name is recognized as a noreturn
+#define assert(_Expression) ((_Expression) ? (void)0 : __assert2(0, 0, 0, 0));
+extern void __assert2(const char *, int, const char *, const char *);
+extern void _wassert(const char * _Message, const char *_File, unsigned _Line);
+void test___assert2() {
+  assert(0);
+  int *p = 0;
+  *p = 0xDEADBEEF; // no-warning
+}
+#undef assert