This is an archive of the discontinued LLVM Phabricator instance.

Differential D157901

[gn build] Force clang_enable_per_target_runtime_dir for Android builds
ClosedPublic

Authored by aeubanks on Aug 14 2023, 10:09 AM.

Details

Reviewers
thakis
Commits
rG204161193156: [gn build] Force clang_enable_per_target_runtime_dir for Android builds
Summary

Since it doesn't work yet.

Diff Detail

Event Timeline

aeubanks created this revision.Aug 14 2023, 10:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2023, 10:09 AM
Herald added a subscriber: danielkiss. · View Herald Transcript
aeubanks requested review of this revision.Aug 14 2023, 10:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2023, 10:09 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks updated this revision to Diff 550012.Aug 14 2023, 10:12 AM

add discourse link

Harbormaster completed remote builds in B252418: Diff 550012.Aug 14 2023, 3:25 PM
thakis accepted this revision.Aug 17 2023, 11:05 AM
This revision is now accepted and ready to land.Aug 17 2023, 11:05 AM
Closed by commit rG204161193156: [gn build] Force clang_enable_per_target_runtime_dir for Android builds (authored by aeubanks). · Explain WhyAug 17 2023, 11:09 AM
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG204161193156: [gn build] Force clang_enable_per_target_runtime_dir for Android builds.
kashifteevno added a subscriber: kashifteevno.Aug 19 2023, 3:25 PM

Revision Contents

PathSize
llvm/
utils/
gn/
build/
toolchain/
7 lines

Diff 550012

llvm/utils/gn/build/toolchain/BUILD.gn

Show First 20 Lines • Show All 213 Lines • ▼ Show 20 Lines
stage2_unix_toolchain("stage2_unix") { stage2_unix_toolchain("stage2_unix") {
toolchain_args = { toolchain_args = {
current_os = host_os current_os = host_os
current_cpu = host_cpu current_cpu = host_cpu
} }
} }
if (android_ndk_path != "") { if (android_ndk_path != "") {
# Android compiler-rt libraries don't really work with per-target runtime
# directories yet so force it off.
# https://discourse.llvm.org/t/handling-version-numbers-in-per-target-runtime-directories/62717.
stage2_unix_toolchain("stage2_android_aarch64") { stage2_unix_toolchain("stage2_android_aarch64") {
toolchain_args = { toolchain_args = {
current_os = "android" current_os = "android"
current_cpu = "arm64" current_cpu = "arm64"
clang_enable_per_target_runtime_dir = false
} }
} }
stage2_unix_toolchain("stage2_android_arm") { stage2_unix_toolchain("stage2_android_arm") {
toolchain_args = { toolchain_args = {
current_os = "android" current_os = "android"
current_cpu = "arm" current_cpu = "arm"
clang_enable_per_target_runtime_dir = false
} }
} }
stage2_unix_toolchain("stage2_android_x64") { stage2_unix_toolchain("stage2_android_x64") {
toolchain_args = { toolchain_args = {
current_os = "android" current_os = "android"
current_cpu = "x64" current_cpu = "x64"
clang_enable_per_target_runtime_dir = false
} }
} }
stage2_unix_toolchain("stage2_android_x86") { stage2_unix_toolchain("stage2_android_x86") {
toolchain_args = { toolchain_args = {
current_os = "android" current_os = "android"
current_cpu = "x86" current_cpu = "x86"
clang_enable_per_target_runtime_dir = false
} }
} }
} }
if (host_os == "mac") { if (host_os == "mac") {
stage2_unix_toolchain("stage2_ios_aarch64") { stage2_unix_toolchain("stage2_ios_aarch64") {
toolchain_args = { toolchain_args = {
current_os = "ios" current_os = "ios"
▲ Show 20 Lines • Show All 189 Lines • Show Last 20 Lines