This is an archive of the discontinued LLVM Phabricator instance.

Differential D157797

[ValueTracking] Add tests for getting knownbits from phi-edges; NFC
ClosedPublic

Authored by goldstein.w.n on Aug 12 2023, 2:43 PM.

Details

Reviewers
nikic
RKSimon
Commits
rG35d916e11be2: [ValueTracking] Add tests for getting knownbits from phi-edges; NFC

Diff Detail

Unit TestsFailed

TimeTest
60,040 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

goldstein.w.n created this revision.Aug 12 2023, 2:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2023, 2:43 PM
Herald added subscribers: foad, StephenFan. · View Herald Transcript
goldstein.w.n requested review of this revision.Aug 12 2023, 2:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2023, 2:43 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D157798: [ValueTracking] Add tests for deducing non-zero based for incoming phi-edges; NFC.Aug 12 2023, 2:44 PM
Harbormaster completed remote builds in B252142: Diff 549651.Aug 12 2023, 5:18 PM
goldstein.w.n updated this revision to Diff 549673.Aug 12 2023, 6:26 PM

Rebase

goldstein.w.n updated this revision to Diff 549675.Aug 12 2023, 6:28 PM

Rebase

Harbormaster completed remote builds in B252164: Diff 549675.Aug 12 2023, 10:12 PM
goldstein.w.n updated this revision to Diff 549719.Aug 13 2023, 10:30 AM

Rebase

Harbormaster completed remote builds in B252201: Diff 549719.Aug 13 2023, 1:07 PM
nikic added inline comments.Aug 14 2023, 3:01 AM
llvm/test/Analysis/ValueTracking/phi-known-bits.ll
25

Here again, I don't think the conditional branches are needed and just br label %T should do.

goldstein.w.n marked an inline comment as done.Aug 14 2023, 9:04 AM
goldstein.w.n updated this revision to Diff 549985.Aug 14 2023, 9:23 AM

Fixup br, add a few more tests

Harbormaster completed remote builds in B252396: Diff 549985.Aug 14 2023, 3:00 PM
nikic accepted this revision.Aug 15 2023, 2:05 AM

LGTM

This revision is now accepted and ready to land.Aug 15 2023, 2:05 AM
goldstein.w.n updated this revision to Diff 550620.Aug 15 2023, 11:06 PM

Rebase

Harbormaster completed remote builds in B252859: Diff 550620.Aug 16 2023, 1:38 AM
This revision was landed with ongoing or failed builds.Aug 22 2023, 8:59 AM
Closed by commit rG35d916e11be2: [ValueTracking] Add tests for getting knownbits from phi-edges; NFC (authored by goldstein.w.n). · Explain Why
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG35d916e11be2: [ValueTracking] Add tests for getting knownbits from phi-edges; NFC.

Revision Contents

PathSize
llvm/
test/
Analysis/
ValueTracking/
449 lines

Diff 549985

llvm/test/Analysis/ValueTracking/phi-known-bits.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -passes=instcombine < %s -S | FileCheck %s
define i8 @phi_ugt_high_bits(i8 %x) {
; CHECK-LABEL: @phi_ugt_high_bits(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp ugt i8 [[X:%.*]], -65
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 64
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp ugt i8 %x, 191
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 64
ret i8 %r
F:
br label %T
}
nikicUnsubmitted
Done
ReplyInline Actions

Here again, I don't think the conditional branches are needed and just br label %T should do.

nikic: Here again, I don't think the conditional branches are needed and just `br label %T` should do.
define i8 @phi_ult_low_bits(i8 %x) {
; CHECK-LABEL: @phi_ult_low_bits(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp ult i8 [[X:%.*]], -64
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: br label [[F]]
; CHECK: F:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[T]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 64
; CHECK-NEXT: ret i8 [[R]]
;
entry:
%cmp = icmp ult i8 %x, 192
br i1 %cmp, label %T, label %F
T:
br label %F
F:
%v = phi i8 [ %x, %entry], [-1, %T]
%r = and i8 %v, 64
ret i8 %r
}
define i8 @phi_ugt_high_bits_fail(i8 %x) {
; CHECK-LABEL: @phi_ugt_high_bits_fail(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp ugt i8 [[X:%.*]], -66
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 64
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp ugt i8 %x, 190
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 64
ret i8 %r
F:
br label %T
}
define i8 @phi_uge_high_bits(i8 %x) {
; CHECK-LABEL: @phi_uge_high_bits(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp ugt i8 [[X:%.*]], -65
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 64
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp uge i8 %x, 192
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 64
ret i8 %r
F:
br label %T
}
define i8 @phi_uge_high_bits_fail(i8 %x) {
; CHECK-LABEL: @phi_uge_high_bits_fail(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp ugt i8 [[X:%.*]], 5
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 1
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp ugt i8 %x, 5
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 1
ret i8 %r
F:
br label %T
}
define i8 @phi_sge_high_bits(i8 %x) {
; CHECK-LABEL: @phi_sge_high_bits(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i8 [[X:%.*]], 95
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 96
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp sge i8 %x, 96
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 96
ret i8 %r
F:
br label %T
}
define i8 @phi_sge_high_bits_fail(i8 %x) {
; CHECK-LABEL: @phi_sge_high_bits_fail(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i8 [[X:%.*]], -2
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 1
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp sge i8 %x, -1
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 1
ret i8 %r
F:
br label %T
}
define i8 @phi_sgt_high_bits(i8 %x) {
; CHECK-LABEL: @phi_sgt_high_bits(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i8 [[X:%.*]], -1
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ 0, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], -128
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp sgt i8 %x, -1
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [0, %F]
%r = and i8 %v, 128
ret i8 %r
F:
br label %T
}
define i8 @phi_sgt_high_bits2(i8 %x) {
; CHECK-LABEL: @phi_sgt_high_bits2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i8 [[X:%.*]], 63
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 64
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp sgt i8 %x, 63
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 64
ret i8 %r
F:
br label %T
}
define i8 @phi_sgt_high_bits_fail(i8 %x) {
; CHECK-LABEL: @phi_sgt_high_bits_fail(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i8 [[X:%.*]], 62
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 64
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp sgt i8 %x, 62
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 64
ret i8 %r
F:
br label %T
}
define i8 @phi_slt_high_bits(i8 %x) {
; CHECK-LABEL: @phi_slt_high_bits(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i8 [[X:%.*]], 0
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], -128
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp slt i8 %x, 0
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 128
ret i8 %r
F:
br label %T
}
define i8 @phi_slt_high_bits2(i8 %x) {
; CHECK-LABEL: @phi_slt_high_bits2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i8 [[X:%.*]], -64
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ 0, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 64
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp slt i8 %x, -64
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [0, %F]
%r = and i8 %v, 64
ret i8 %r
F:
br label %T
}
define i8 @phi_slt_high_bits_fail(i8 %x) {
; CHECK-LABEL: @phi_slt_high_bits_fail(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i8 [[X:%.*]], -63
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ 0, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 64
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp slt i8 %x, -63
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [0, %F]
%r = and i8 %v, 64
ret i8 %r
F:
br label %T
}
define i8 @phi_sle_high_bits(i8 %x) {
; CHECK-LABEL: @phi_sle_high_bits(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i8 [[X:%.*]], -64
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ 0, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 64
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp sle i8 %x, -65
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [0, %F]
%r = and i8 %v, 64
ret i8 %r
F:
br label %T
}
define i8 @phi_sle_low_bits(i8 %x) {
; CHECK-LABEL: @phi_sle_low_bits(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i8 [[X:%.*]], 65
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: br label [[F]]
; CHECK: F:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[T]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 64
; CHECK-NEXT: ret i8 [[R]]
;
entry:
%cmp = icmp sle i8 %x, 64
br i1 %cmp, label %T, label %F
T:
br label %F
F:
%v = phi i8 [ %x, %entry], [-1, %T]
%r = and i8 %v, 64
ret i8 %r
}
define i8 @phi_sle_high_bits_fail(i8 %x) {
; CHECK-LABEL: @phi_sle_high_bits_fail(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i8 [[X:%.*]], 1
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], -128
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp sle i8 %x, 0
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 128
ret i8 %r
F:
br label %T
}
define i8 @phi_sle_high_bits_fail2(i8 %x) {
; CHECK-LABEL: @phi_sle_high_bits_fail2(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i8 [[X:%.*]], -63
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 64
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%cmp = icmp sle i8 %x, -64
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 64
ret i8 %r
F:
br label %T
}
define i8 @phi_ugt_high_bits_and_known(i8 %xx) {
; CHECK-LABEL: @phi_ugt_high_bits_and_known(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[X:%.*]] = or i8 [[XX:%.*]], 1
; CHECK-NEXT: [[CMP:%.*]] = icmp ugt i8 [[X]], -65
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 65
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%x = or i8 %xx, 1
%cmp = icmp ugt i8 %x, 191
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 65
ret i8 %r
F:
br label %T
}
define i8 @phi_ugt_high_bits_and_known_todo_high_depths(i8 %xx, i8 %y, i8 %z) {
; CHECK-LABEL: @phi_ugt_high_bits_and_known_todo_high_depths(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[YY:%.*]] = and i8 [[Y:%.*]], -2
; CHECK-NEXT: [[XXX:%.*]] = and i8 [[YY]], [[XX:%.*]]
; CHECK-NEXT: [[ZZ:%.*]] = or i8 [[Z:%.*]], 1
; CHECK-NEXT: [[X:%.*]] = add i8 [[XXX]], [[ZZ]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ugt i8 [[X]], -65
; CHECK-NEXT: br i1 [[CMP]], label [[T:%.*]], label [[F:%.*]]
; CHECK: T:
; CHECK-NEXT: [[V:%.*]] = phi i8 [ [[X]], [[ENTRY:%.*]] ], [ -1, [[F]] ]
; CHECK-NEXT: [[R:%.*]] = and i8 [[V]], 65
; CHECK-NEXT: ret i8 [[R]]
; CHECK: F:
; CHECK-NEXT: br label [[T]]
;
entry:
%yy = and i8 %y, -2
%xxx = and i8 %xx, %yy
%zz = or i8 %z, 1
%x = add i8 %xxx, %zz
%cmp = icmp ugt i8 %x, 191
br i1 %cmp, label %T, label %F
T:
%v = phi i8 [ %x, %entry], [-1, %F]
%r = and i8 %v, 65
ret i8 %r
F:
br label %T
}