This is an archive of the discontinued LLVM Phabricator instance.

[mlir][gpu] Add documentation for the new GPU compilation mechanism
ClosedPublic

Authored by fmorac on Aug 8 2023, 5:23 PM.

Details

Summary

Adds documentation to the GPU dialect docs giving a general overview of the new
compilation mechanism introduced in the patch series ending in D154153.

Diff Detail

Event Timeline

fmorac created this revision.Aug 8 2023, 5:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2023, 5:23 PM
fmorac published this revision for review.Aug 8 2023, 5:24 PM
mehdi_amini accepted this revision.Aug 8 2023, 9:56 PM
mehdi_amini added inline comments.
mlir/docs/Dialects/GPU.md
41

There is a page of the mlir website also to document depreciation, worth mentioning it there and linking to this doc, after this patch lands.

52
57

I would rather see the syntax using the --pass-pipeline format, making nesting explicit.

This revision is now accepted and ready to land.Aug 8 2023, 9:56 PM
fmorac updated this revision to Diff 548588.Aug 9 2023, 5:56 AM
fmorac marked 2 inline comments as done.
fmorac edited the summary of this revision. (Show Details)

Updated the docs with the comments.

mlir/docs/Dialects/GPU.md
41

I saw it, I'll create a notice there too. Should we add a deprecation warning on the passes, so if a user uses it they get a warning?