This is an archive of the discontinued LLVM Phabricator instance.

[flang][tests] Enable some fixed tests, disable some with valid new errors
ClosedPublic

Authored by klausler on Aug 8 2023, 4:56 PM.

Details

Summary

Many gfortran regression tests that were disabled because they failed
have been fixed in llvm-project/main, and can now be removed from the
DisabledFiles.cmake file. Some tests that were compiling and running
no longer do so because they contain valid errors that are now detected
by flang at compilation time.

Diff Detail

Repository
rT test-suite

Event Timeline

klausler created this revision.Aug 8 2023, 4:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2023, 4:56 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
klausler requested review of this revision.Aug 8 2023, 4:56 PM
tarunprabhu added a reviewer: luporl.

Adding additional reviewers who can check that enabling these works on ARM.

Adding additional reviewers who can check that enabling these works on ARM.

Time is of the essence; there is a Clang build bot that is failing because it needs to run the test suite against an f18 compiler that it builds as a test.

If you have no objection, I'm going to push this patch soon, and you can do a post-commit review.

kiranchandramohan accepted this revision.Aug 9 2023, 9:00 AM

Tests passed on AArch64 for me.

I have an unrelated issue for regression__assign_3_f90. This is not related to this change.

This revision is now accepted and ready to land.Aug 9 2023, 9:00 AM
tblah accepted this revision.Aug 9 2023, 9:07 AM

Works with HLFIR for me +1