InterfacePointerType is dereferenced and should not be null.
Details
Diff Detail
Event Timeline
clang/lib/CodeGen/CGObjC.cpp | ||
---|---|---|
222–223 | The previous code included a guarantee that InterfacePointerType->getInterfaceType() is non-null and this change loses that assurance. Presumably, we never ran into a violation of that guarantee in the past (since a SIGSEGV would likely have occurred below otherwise), but perhaps we should consider an assertion to ensure that guarantee is still met. |
clang/lib/CodeGen/CGObjC.cpp | ||
---|---|---|
222–223 | Hmmm... I guess in that case it was just make more sense to keep the old code and add an assert for InterfacePointerType? |
clang/lib/CodeGen/CGObjC.cpp | ||
---|---|---|
222–223 | Ah, yes, I think that is a better approach! |
Pre-merge check fails are unrelated - fatal error C1060: compiler is out of heap space
The previous code included a guarantee that InterfacePointerType->getInterfaceType() is non-null and this change loses that assurance. Presumably, we never ran into a violation of that guarantee in the past (since a SIGSEGV would likely have occurred below otherwise), but perhaps we should consider an assertion to ensure that guarantee is still met.