[NFC][Clang] Fix static analyzer concern about null value dereference

[eandrews]

Summary

InterfacePointerType is dereferenced and should not be null.

[aaron.ballman]

LGTM

[tahonermann]

clang/lib/CodeGen/CGObjC.cpp

224–226

The previous code included a guarantee that InterfacePointerType->getInterfaceType() is non-null and this change loses that assurance. Presumably, we never ran into a violation of that guarantee in the past (since a SIGSEGV would likely have occurred below otherwise), but perhaps we should consider an assertion to ensure that guarantee is still met.

[eandrews]

clang/lib/CodeGen/CGObjC.cpp

224–226

Hmmm... I guess in that case it was just make more sense to keep the old code and add an assert for InterfacePointerType?

[tahonermann]

clang/lib/CodeGen/CGObjC.cpp

224–226

Ah, yes, I think that is a better approach!

[eandrews]

Applied review comments to use an assert instead

[tahonermann]

Looks good to me. Thanks, Elizabeth!

[eandrews]

Pre-merge check fails are unrelated - fatal error C1060: compiler is out of heap space

clang/lib/CodeGen/CGObjC.cpp

llvm::Value *CodeGenFunction::EmitObjCCollectionLiteral(const Expr *E,
   llvm::Value *Count =
     llvm::ConstantInt::get(CGM.getTypes().ConvertType(ArgQT), NumElements);
   Args.add(RValue::get(Count), ArgQT);
 
   // Generate a reference to the class pointer, which will be the receiver.
   Selector Sel = MethodWithObjects->getSelector();
   QualType ResultType = E->getType();
   const ObjCObjectPointerType *InterfacePointerType
     = ResultType->getAsObjCInterfacePointerType();
+  assert(InterfacePointerType && "Unexpected InterfacePointerType - null");
   ObjCInterfaceDecl *Class
     = InterfacePointerType->getObjectType()->getInterface();
   CGObjCRuntime &Runtime = CGM.getObjCRuntime();
   llvm::Value *Receiver = Runtime.GetClass(*this, Class);
 
   // Generate the message send.
   RValue result = Runtime.GenerateMessageSend(
       *this, ReturnValueSlot(), MethodWithObjects->getReturnType(), Sel,
       Receiver, Args, Class, MethodWithObjects);