[ValueTracking] Check likely to be canonicalized constant operands first in ; NFC

[goldstein.w.n]

Summary

Checking operands that a likely to be canonicalized constants first makes sense
from a compile time perspective as it puts whats expected to be a cheaper check first.

[nikic]

llvm/lib/Analysis/ValueTracking.cpp

2109

Does this canonicalization actually exist?

[goldstein.w.n]

llvm/lib/Analysis/ValueTracking.cpp

2109

No. Happy to drop but think its not difference either way.

[nikic]

LGTM

[goldstein.w.n]

Drop changes to select

llvm/lib/Analysis/ValueTracking.cpp

2109

I dropped the select changes.

[goldstein.w.n]

Rebase before isKnownNonZero patch

llvm/lib/Analysis/ValueTracking.cpp

case Instruction::UDiv:
     return false;
   case Instruction::Mul:
     return isKnownToBeAPowerOfTwo(I->getOperand(1), OrZero, Depth, Q) &&
            isKnownToBeAPowerOfTwo(I->getOperand(0), OrZero, Depth, Q) &&
            (OrZero || isKnownNonZero(I, Depth, Q));
   case Instruction::And:
     // A power of two and'd with anything is a power of two or zero.
     if (OrZero &&
-        (isKnownToBeAPowerOfTwo(I->getOperand(0), /*OrZero*/ true, Depth, Q) ||
-         isKnownToBeAPowerOfTwo(I->getOperand(1), /*OrZero*/ true, Depth, Q)))
+        (isKnownToBeAPowerOfTwo(I->getOperand(1), /*OrZero*/ true, Depth, Q) ||
+         isKnownToBeAPowerOfTwo(I->getOperand(0), /*OrZero*/ true, Depth, Q)))
       return true;
     // X & (-X) is always a power of two or zero.
     if (match(I->getOperand(0), m_Neg(m_Specific(I->getOperand(1)))) ||
         match(I->getOperand(1), m_Neg(m_Specific(I->getOperand(0)))))
       return OrZero || isKnownNonZero(I->getOperand(0), Depth, Q);
     return false;
   case Instruction::Add: {
     // Adding a power-of-two or zero to the same power-of-two or zero yields
if (OrZero || Q.IIQ.hasNoUnsignedWrap(VOBO) ||
         // If OrZero isn't set, we cannot give back a zero result.
         // Make sure either the LHS or RHS has a bit set.
         if (OrZero || RHSBits.One.getBoolValue() || LHSBits.One.getBoolValue())
           return true;
     }
     return false;
   }
   case Instruction::Select:
-    return isKnownToBeAPowerOfTwo(I->getOperand(1), OrZero, Depth, Q) &&
-           isKnownToBeAPowerOfTwo(I->getOperand(2), OrZero, Depth, Q);
+    return isKnownToBeAPowerOfTwo(I->getOperand(2), OrZero, Depth, Q) &&
+           isKnownToBeAPowerOfTwo(I->getOperand(1), OrZero, Depth, Q);
   case Instruction::PHI: {
     // A PHI node is power of two if all incoming values are power of two, or if
     // it is an induction variable where in each step its value is a power of
     // two.
     auto *PN = cast<PHINode>(I);
     SimplifyQuery RecQ = Q;
 
     // Check if it is an induction variable and always power of two.