[lldb] Make TSan errors fatal when running the test suite

[JDevlieghere]

Summary

Set the halt_on_error runtime flag to make TSan errors fatal when running the test suite. For the API tests the environment variables are set conditionally on whether the TSan is enabled. The Shell tests don't have that logic and I don't think it's worth duplicating it as setting the environment variable is harmless. For consistency, I've also mirrored the ASAN option (detect_stack_use_after_return=1) for the Shell tests.

[JDevlieghere]

Include the unit tests

[bulbazord]

LGTM

lldb/test/API/lit.cfg.py

if is_configured("llvm_use_sanitizer"):
     if "Address" in config.llvm_use_sanitizer:
         config.environment["ASAN_OPTIONS"] = "detect_stack_use_after_return=1"
         if "Darwin" in config.host_os:
             config.environment["DYLD_INSERT_LIBRARIES"] = find_sanitizer_runtime(
                 "libclang_rt.asan_osx_dynamic.dylib"
             )
 
     if "Thread" in config.llvm_use_sanitizer:
+        config.environment["TSAN_OPTIONS"] = "halt_on_error=1"
         if "Darwin" in config.host_os:
             config.environment["DYLD_INSERT_LIBRARIES"] = find_sanitizer_runtime(
                 "libclang_rt.tsan_osx_dynamic.dylib"
             )
 
 if "DYLD_INSERT_LIBRARIES" in config.environment and platform.system() == "Darwin":
     config.python_executable = find_python_interpreter()
 

lldb/test/Shell/lit.cfg.py

[
         "FREEBSD_LEGACY_PLUGIN",
         "HOME",
         "TEMP",
         "TMP",
         "XDG_CACHE_HOME",
     ]
 )
 
+# Enable sanitizer runtime flags.
+config.environment["ASAN_OPTIONS"] = "detect_stack_use_after_return=1"
+config.environment["TSAN_OPTIONS"] = "halt_on_error=1"
+
 # Support running the test suite under the lldb-repro wrapper. This makes it
 # possible to capture a test suite run and then rerun all the test from the
 # just captured reproducer.
 lldb_repro_mode = lit_config.params.get("lldb-run-with-repro", None)
 if lldb_repro_mode:
     config.available_features.add("lldb-repro")
     lit_config.note("Running Shell tests in {} mode.".format(lldb_repro_mode))
     toolchain.use_lldb_repro_substitutions(config, lldb_repro_mode)

lldb/test/Unit/lit.cfg.py

[
         "PATH",
         "TEMP",
         "TMP",
         "XDG_CACHE_HOME",
     ]
 )
 llvm_config.with_environment("PATH", os.path.dirname(sys.executable), append_path=True)
 
+# Enable sanitizer runtime flags.
+config.environment["ASAN_OPTIONS"] = "detect_stack_use_after_return=1"
+config.environment["TSAN_OPTIONS"] = "halt_on_error=1"
+
 # testFormat: The test format to use to interpret tests.
 config.test_format = lit.formats.GoogleTest(config.llvm_build_mode, "Tests")