[libc++] Fix problems with GCC 13 and switch to it in the CI

[philnik]

libcxx/test/std/utilities/meta/meta.rel/is_convertible.pass.cpp

117–126

This code seems bogus to me and GCC disagrees with clang here. I've filed https://github.com/llvm/llvm-project/issues/64402, since I'm quite certain that the typedef above shouldn't be accepted. If the clang folks agree with me I'll also file a bug report against GCC.

[philnik]

Try to fix CI

[philnik]

Try to fix CI

[philnik]

Fixes

libcxx/test/std/utilities/meta/meta.rel/is_convertible.pass.cpp

117–126

Never mind. This is actually valid code and GCC probably has a bug in __is_convertible.

[Mordante]

Thanks for working on this! Please update the official supported GCC version in the libc++ documentation,

libcxx/test/std/utilities/meta/meta.rel/is_convertible.pass.cpp

121

All versions of GCC or just 13?

[philnik]

Address comments

[philnik]

libcxx/test/std/utilities/meta/meta.rel/is_convertible.pass.cpp

121

Just GCC 13

[Mordante]

In general happy, but I would like to have a short look after my comment has been addressed.

libcxx/test/std/utilities/meta/meta.rel/is_convertible.pass.cpp

121

Maybe add that information in the comment and in the header too. something like
TODO Enable again when https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110904 is fixed. The bug was introduced in GCC 13.

[philnik]

Address comments

libcxx/test/std/utilities/meta/meta.rel/is_convertible.pass.cpp

121

It's already fixed in the GCC trunk. I've just made this an LLVM 19 TODO, since we will probably switch to GCC 14 then.

[Mordante]

LGTM!

libcxxabi/test/catch_member_function_pointer_02.pass.cpp

18

After you land this can you make a follow-up draft review to remove the gcc-11 and gcc-12 XFAILS here and elsewhere.
I think it's good to give it a CI spin and land it when the CI happy.

[philnik]

libcxxabi/test/catch_member_function_pointer_02.pass.cpp

18

That was my plan.

libcxx/include/__type_traits/is_nothrow_constructible.h

 #include <cstddef>
 
 #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
 #  pragma GCC system_header
 #endif
 
 _LIBCPP_BEGIN_NAMESPACE_STD
 
-#if __has_builtin(__is_nothrow_constructible)
+// GCC is disabled due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106611
+#if __has_builtin(__is_nothrow_constructible) && !defined(_LIBCPP_COMPILER_GCC)
 
 template < class _Tp, class... _Args>
 struct _LIBCPP_TEMPLATE_VIS is_nothrow_constructible
     : public integral_constant<bool, __is_nothrow_constructible(_Tp, _Args...)> {};
 #else
 
 template <bool, bool, class _Tp, class... _Args>
 struct __libcpp_is_nothrow_constructible;

libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp

 // REQUIRES: locale.en_US.UTF-8
 // UNSUPPORTED: no-localization
 // UNSUPPORTED: c++03
 
 // TODO: Investigate these failures which break the CI.
 // UNSUPPORTED: clang-15, clang-16, clang-17, clang-18
 
 // TODO: Investigate this failure on GCC 12 (in Ubuntu Jammy)
-// UNSUPPORTED: gcc-12
+// UNSUPPORTED: gcc-12, gcc-13
 
 // RUN: %{cxx} %{flags} %s -o %t.exe %{compile_flags} -g %{link_flags}
 // Ensure locale-independence for unicode tests.
 // RUN: env LANG=en_US.UTF-8 %{gdb} -nx -batch -iex "set autoload off" -ex "source %S/../../../utils/gdb/libcxx/printers.py" -ex "python register_libcxx_printer_loader()" -ex "source %S/gdb_pretty_printer_test.py" %t.exe
 
 #include <bitset>
 #include <deque>
 #include <list>

libcxx/test/std/algorithms/robust_against_adl.compile.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // <algorithm>
 
 // https://buildkite.com/llvm-project/libcxx-ci/builds/15823#0184fc0b-d56b-4774-9e1d-35fe24e09e37
 // It seems like the CI gcc version is buggy. I can't reproduce the failure on my system or on
 // godbolt (https://godbolt.org/z/rsPv8e8fn).
-// UNSUPPORTED: gcc-12
+// UNSUPPORTED: gcc-12, gcc-13
 
 #include <algorithm>
 #include <cstddef>
 #include <functional>
 #include <iterator>
 
 #include "test_macros.h"
 

libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.char_array.pass.cpp

 //===----------------------------------------------------------------------===//
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17
 // TODO FMT __builtin_memcpy isn't constexpr in GCC
-// UNSUPPORTED: gcc-12
+// UNSUPPORTED: gcc-12, gcc-13
 
 // <format>
 
 // C++23 the formatter is a debug-enabled specialization.
 // [format.functions]/25
 //   Preconditions: formatter<remove_cvref_t<Ti>, charT> meets the
 //   BasicFormatter requirements ([formatter.requirements]) for each Ti in
 //   Args.

libcxx/test/std/utilities/meta/meta.rel/is_convertible.pass.cpp

int main(int, char**)
     test_is_not_convertible<Function*, Function&> ();
     test_is_convertible<Function*, Function*> ();
 
     test_is_not_convertible<Function*, Array> ();
     test_is_not_convertible<Function*, Array&> ();
     test_is_not_convertible<Function*, char> ();
     test_is_not_convertible<Function*, char&> ();
     test_is_not_convertible<Function*, char*> ();
 
     // Non-referencable function type
     static_assert((!std::is_convertible<ConstFunction, Function>::value), "");
+// TODO(LLVM-19): Re-enable this once we switch to GCC 14. This is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109680
+#ifndef TEST_COMPILER_GCC
     static_assert((!std::is_convertible<ConstFunction, Function*>::value), "");
     static_assert((!std::is_convertible<ConstFunction, Function&>::value), "");
     static_assert((!std::is_convertible<ConstFunction, Function&&>::value), "");
+#endif
     static_assert((!std::is_convertible<Function*, ConstFunction>::value), "");
     static_assert((!std::is_convertible<Function&, ConstFunction>::value), "");
     static_assert((!std::is_convertible<ConstFunction, ConstFunction>::value), "");
     static_assert((!std::is_convertible<ConstFunction, void>::value), "");
 
     // Array
     test_is_not_convertible<Array, void> ();
     test_is_not_convertible<Array, Function> ();
     test_is_not_convertible<Array, Function&> ();
     test_is_not_convertible<Array, Function*> ();
     test_is_not_convertible<Array, Array> ();
 

libcxx/test/std/utilities/meta/meta.rel/is_convertible_fallback.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03
 
 // ADDITIONAL_COMPILE_FLAGS: -D _LIBCPP_USE_IS_CONVERTIBLE_FALLBACK
 
+// UNSUPPORTED: gcc-13
+
 // type_traits
 
 // is_convertible
 
 // Test the fallback implementation.
 
 // libc++ provides a fallback implementation of the compiler trait
 // `__is_convertible` with the same name when clang doesn't.
 // Because this test forces the use of the fallback even when clang provides
 // it causing a keyword incompatibility.
 
 #include "test_macros.h"
 TEST_CLANG_DIAGNOSTIC_IGNORED("-Wkeyword-compat")
 
 #include "is_convertible.pass.cpp"

libcxx/utils/ci/buildkite-pipeline.yml

 # Theses numbers are available in all runners, making it easier to update the
 # version number.
 env:
     # LLVM POST-BRANCH bump version
     # LLVM POST-BRANCH add compiler test for ToT - 1, e.g. "Clang 17"
     # LLVM RELEASE bump remove compiler ToT - 3, e.g. "Clang 15"
     LLVM_STABLE_VERSION: "16"
     LLVM_HEAD_VERSION: "17"
-    GCC_STABLE_VERSION: "12"
+    GCC_STABLE_VERSION: "13"
 steps:
   #
   # Light pre-commit tests for things like formatting or when people forget
   # to update generated files.
   #
   - label: "Format"
     command: "libcxx/utils/ci/run-buildbot check-format"
     artifact_paths:

libcxx/utils/libcxx/test/params.py

_warningFlags = [
     "-Wno-local-type-template-args",
     "-Wno-c++11-extensions",
 
     # TODO(philnik) This fails with the PSTL.
     "-Wno-unknown-pragmas",
     # Don't fail compilation in case the compiler fails to perform the requested
     # loop vectorization.
     "-Wno-pass-failed",
+
+    # TODO: Find out why GCC warns in lots of places (is this a problem with always_inline?)
+    "-Wno-dangling-reference",
+    "-Wno-mismatched-new-delete",
+    "-Wno-redundant-move",
+
+    # This doesn't make sense in real code, but we have to test it because the standard requires us to not break
+    "-Wno-self-move",
 ]
 
 _allStandards = ["c++03", "c++11", "c++14", "c++17", "c++20", "c++23", "c++26"]
 
 
 def getStdFlag(cfg, std):
     # TODO(LLVM-17) Remove this clang-tidy-16 work-around
     if std == "c++23":

libcxxabi/test/catch_member_function_pointer_02.pass.cpp

 // UNSUPPORTED: c++03, c++11, c++14
 // UNSUPPORTED: no-exceptions
 
 // Support for catching a function pointer including noexcept was shipped in macOS 10.13
 // XFAIL: stdlib=apple-libc++ && target={{.+}}-apple-macosx10.{{9|10|11|12}}
 
 // GCC supports noexcept function types but this test still fails.
 // This is likely a bug in their implementation. Investigation needed.
-// XFAIL: gcc-11, gcc-12
+// XFAIL: gcc-11, gcc-12, gcc-13
 
 #include <cassert>
 
 struct X {
   template<bool Noexcept> void f() noexcept(Noexcept) {}
 };
 template<bool Noexcept> using FnType = void (X::*)() noexcept(Noexcept);