[clang] NFC: Avoid double allocation when generating command line

[jansvoboda11]

Summary

This patch makes use of the infrastructure established in D157046 to avoid needless allocations via StringSaver.

Depends on D157046.

[benlangmuir]

Dupe of https://reviews.llvm.org/D157048 ?

[jansvoboda11]

In D157050#4559138, @benlangmuir wrote:

Dupe of https://reviews.llvm.org/D157048 ?

Yes, weird. Closing this one.

clang/lib/Frontend/CompilerInvocation.cpp

void CompilerInvocation::generateCC1CommandLine(
   GeneratePreprocessorArgs(*PreprocessorOpts, Consumer, *LangOpts, FrontendOpts,
                            CodeGenOpts);
   GeneratePreprocessorOutputArgs(PreprocessorOutputOpts, Consumer,
                                  FrontendOpts.ProgramAction);
   GenerateDependencyOutputArgs(DependencyOutputOpts, Consumer);
 }
 
 std::vector<std::string> CompilerInvocation::getCC1CommandLine() const {
-  // Set up string allocator.
-  llvm::BumpPtrAllocator Alloc;
-  llvm::StringSaver Strings(Alloc);
-  auto SA = [&Strings](const Twine &Arg) { return Strings.save(Arg).data(); };
-
-  // Synthesize full command line from the CompilerInvocation, including "-cc1".
-  SmallVector<const char *, 32> Args{"-cc1"};
-  generateCC1CommandLine(Args, SA);
-
-  // Convert arguments to the return type.
-  return std::vector<std::string>{Args.begin(), Args.end()};
+  std::vector<std::string> Args{"-cc1"};
+  generateCC1CommandLine(
+      [&Args](const Twine &Arg) { Args.push_back(Arg.str()); });
+  return Args;
 }
 
 void CompilerInvocation::resetNonModularOptions() {
   getLangOpts()->resetNonModularOptions();
   getPreprocessorOpts().resetNonModularOptions();
 }
 
 void CompilerInvocation::clearImplicitModuleBuildOptions() {